great backup plugin – some problems present

Works nicely!

Despite some upload errors in the logs, the retry option apparently saves the day, as the archive files appear at the destinations (FTP, Dropbox) and I can extract all the files. Checksums are correct, so I think the logged errors have no effect.

I would buy the Pro version, if only it had the archive encryption option using PGP public keys.

UPD: changed my rating from 5 to 2. Reason:
The backup upload implementation doesn’t honour wp-config.php PROXY settings. Thus, the plugin won’t work correctly in some environments.

For example, backup upload to clouds (i.e. Dropbox) will fail if the server is behind a forward proxy w/firewall.

Confirmation:

cat ./wp-content/plugins/backwpup/incclass-destination-dropbox.php | grep curl
                $ch = curl_init();
                        curl_setopt( $ch, CURLOPT_POST, true );
                        curl_setopt( $ch, CURLOPT_POSTFIELDS, $args );
                        curl_setopt( $ch, CURLOPT_URL, $url );
                        curl_setopt( $ch, CURLOPT_CUSTOMREQUEST, 'PUT' );
                        curl_setopt( $ch, CURLOPT_POSTFIELDS, $data );
                        curl_setopt( $ch, CURLOPT_URL, $url . $args );
                        curl_setopt( $ch, CURLOPT_BINARYTRANSFER, true );
                        curl_setopt( $ch, CURLOPT_URL, $url . $args );
                curl_setopt( $ch, CURLOPT_USERAGENT, BackWPup::get_plugin_data( 'User-Agent' ) );
                curl_setopt( $ch, CURLOPT_RETURNTRANSFER, true );
                        curl_setopt( $ch, CURLOPT_SSLVERSION, 1 );
                        curl_setopt( $ch, CURLOPT_SSL_VERIFYPEER, true );
                        $curl_version = curl_version();
                        if ( strstr( $curl_version['ssl_version'], 'NSS/' ) === false ) {
                                curl_setopt( $ch, CURLOPT_SSL_CIPHER_LIST,
                                curl_setopt( $ch, CURLOPT_PROTOCOLS, CURLPROTO_HTTPS );
                                curl_setopt( $ch, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTPS );
                        curl_setopt( $ch, CURLOPT_CAINFO, BackWPup::get_plugin_data( 'cacert' ) );
                        curl_setopt( $ch, CURLOPT_CAPATH, dirname( BackWPup::get_plugin_data( 'cacert' ) ) );
                        curl_setopt( $ch, CURLOPT_SSL_VERIFYPEER, false );
                curl_setopt( $ch, CURLOPT_HTTPHEADER, $headers );
                        echo curl_exec( $ch );
                        curl_setopt( $ch, CURLOPT_HEADER, true );
                        if ( 0 == curl_errno( $ch ) ) {
                                $responce = explode( "\r\n\r\n", curl_exec( $ch ), 2 );
                $status = curl_getinfo( $ch );
                } elseif ( isset( $output['error'] ) || $status['http_code'] >= 300 || $status['http_code'] < 200 || curl_errno( $ch ) > 0 ) {
                        } elseif ( 0 != curl_errno( $ch ) ) {
                                $message = '(' . curl_errno( $ch ) . ') ' . curl_error( $ch );
                        curl_close( $ch );

As you can see, the module responsible for Dropbox data upload doesn’t set the relevant curl option curl_setopt($ch, CURLOPT_PROXY, ...);

That option must be set to some combination of WP_PROXY_HOST, WP_PROXY_PORT and other relevant WP_PROXY_… vars defined in wp-config.php (see also curl_setopt($ch, CURLOPT_PROXYUSERPWD, ...);).

Please refer to ./wp-includes/class-wp-http-proxy.php for WP_HTTP_Proxy API.

I will update my review should this behaviour be corrected.

• This topic was modified 9 years, 5 months ago by guttenburgerm3. Reason: important feature (HTTP proxy support) missing