Having issues with variation weights

  • Resolved degree

    (@degree)


    9 years, 5 months ago

    Hi,

    I’m having an issue where for variation products, the weight is only being taken from the product.

    I think this is due to the way the WbsPackage class collects the lines and gets the data, but I haven’t been able to find the route cause yet.

    Does anyone know of a way to fix this so that it uses the variation weight (if it exists) rather then just use 0 for no base product weight?

    Also there is a bug where there is a extra span in the currency symbol in settings. I think this is due to the filtering that is on get_woocommerce_currency_symbol() function – called on line 284 of WbsSettingsHtmlTools.php.

    Cheers!

    • This topic was modified 9 years, 5 months ago by degree.
Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Dan

    (@dangoodman)

    9 years, 5 months ago

    Hi,

    The plugin should be working fine with variations weights. Technically, it just gets items data from Woocommerce which should be correct unless there are some plugins/hooks breaking it. Make sure the issue is reproducible with other plugins disabled and default theme active. If it is, please let me know how to reproduce it on the demo staging.

    As of the second issue, I’m not sure what you mean. Could describe the issue in more detail? Steps to reproduce?

    Thread Starter degree

    (@degree)

    9 years, 5 months ago

    Hi Dan,

    I’ll try reproduce it on your demo site now.

    For the second issue, on the ‘Weight Rate’ charge text box, the unit of currency has a extra span element around it which shows up inside the side box. I can’t get you a screenshot at the moment, but it isn’t happening on your demo. I am using a £ shop though and the free version.

    Is the variations support only for the paid plugin?

    Thread Starter degree

    (@degree)

    9 years, 5 months ago

    The mark up for the second issue is as follows:

    <span class="wbs-input-group-addon"><span>$</span></span>

    • This reply was modified 9 years, 5 months ago by degree. Reason: Fixing the mark up
    Thread Starter degree

    (@degree)

    9 years, 5 months ago

    The mark up for the second issue is as follows:

    <span class="wbs-input-group-addon">$&lspan>$</span></span>

    Plugin Author Dan

    (@dangoodman)

    9 years, 5 months ago

    Apparently, something on your installation wraps the currency symbol with a span since by default it’s not there. It’s not an error though, currency_symbol is expected to be an html string. I’ll remove esc_html() for it in the next plugin version.

    Variations are supported in both plugin versions.

    Did you able to reproduce the issue on the demo site?

    • This reply was modified 9 years, 5 months ago by Dan.
    • This reply was modified 9 years, 5 months ago by Dan.
    Thread Starter degree

    (@degree)

    9 years, 5 months ago

    Okay, not to worry thanks for taking a look, I must have a filter being triggered somewhere.

    I couldn’t replicate it on the demo site and when I began work this morning, I couldn’t recreate the issue either on the multi-site I’m working on.

    I imagine that I was just being a donkey and had some rules that were crossing over, apologies!

    Thanks for all your help.

    Do you have a donation area at all? I don’t need the full plugin but I would like to make a contribution for your time 🙂

    • This reply was modified 9 years, 5 months ago by degree.
    Plugin Author Dan

    (@dangoodman)

    9 years, 5 months ago

    No need in donations, “thanks” is enough. Glad to help 🙂

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘Having issues with variation weights’ is closed to new replies.