• Resolved amddtim

    (@amddtim)


    Despite the fact that there are -ms prefixes applied to the output styles, use of this plugin is really borked in IE11. I don’t think you’re far off though. I don’t think this will get corrected in time for me to use a patch on production, so I’ll have to hack into the code in the meantime. But it would be really nice to have addressed. If there were a Github repo, I’d be willing to submit a PR.

    The page I need help with: [log in to see the link]

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor Andrea Gandino

    (@andg)

    Hello there,

    thanks for your feedback! Regarding your issue, it’s hard for us to understand what’s wrong with Grids on IE11 in the page you’ve provided, since you’ve probably done some work there.

    At the moment, Grids’ repo is private, however we’d be very interested in reviewing any changes that you would make to the CSS source code, so that they can be integrated in the next update of the plugin.

    Would you mind writing us an email at info (at) justevolve (dot) it, with the suggested changes?

    Again, thank you very much for your feedback!

    Andrea

    Thread Starter amddtim

    (@amddtim)

    Hi Andrea,

    Yes, that link has now been updated with my changes so it’s not a good illustration of the issue any longer. If you’d like, I can reverse the change for you to see it.

    I’ll email you the suggestion, but for anyone else who landed on this page with the same issues, it mostly comes down to tweaks in Area.php and Section.php to get the -ms generated inline CSS more in line with the recommendations here. You can ignore the Autoprefixer stuff and just focus on the output. Specifically, you can’t use the repeat function for grid columns or rows.

    The more hefty, eventual core update should probably use grid-template, since we also have a problem with IE11 not using grid gap. I went with a more hacky CSS approach (like how Bootstrap or Foundation build column gaps with flex and margins) for expediency sake. But that article I linked should give you all the ammunition you need to update this plugin.

    And for what it’s worth, I have been very happy with this plugin otherwise! Definitely something that should have been in the WP block core in the first place.

    Plugin Contributor Simone Maranzana

    (@simo_m)

    Marking this as solved

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘IE11 Compatability’ is closed to new replies.