Import from HTML ignores some code

  • Resolved Jeff Cohan

    (@jdcohan)


    13 years, 6 months ago

    Being a huge fan of WPTR, I just installed and tested TablePress. Many changes look really good and promising.

    Odd problem, though. When I tried to import an HTML table into TablePress (one which imported SUCCESSFULLY in WPTR earlier tonight on another site), four cells didn’t import properly.

    The source code for each of these four cells follows the same format:

    <td>SOME TEXT HERE<br><span class="descrip">DESCRIPTION HERE</span></td>

    In each case, the import process fails to import “SOME TEXT HERE”; it starts with the line-break.

    TIA for looking into this.

    PS: I can send you the full HTML source file if that would help.

    http://ww.wp.xz.cn/extend/plugins/tablepress/

Viewing 10 replies - 1 through 10 (of 10 total)
  • Plugin Author Tobias Bäthge

    (@tobiasbg)

    13 years, 6 months ago

    Hi,

    thanks for your report!

    This obviously seems to be a bug, and I’ll gladly try to fix it! I probably missed something when rewriting the code for the HTML import in TablePress, compared to that of WP-Table Reloaded.

    To have good data to test changes with, it would indeed be awesome, if you could email me your HTML file. My email address is in the main plugin file of TablePress, tablepress.php.

    Meanwhile, I suggest that you import the HTML file into WP-Table Reloaded, and then export to CSV there again. The import of the CSV file should then work just fine, with all content, in TablePress.

    Regards,
    Tobias

    Thread Starter Jeff Cohan

    (@jdcohan)

    13 years, 6 months ago

    Tobias –

    The HTML file is on its way via email attachment.

    PS: You “Meanwhile,…” suggestion did, indeed, work:

    HTML -> WPTR -> CSV -> TablePress = success.

    Jeff

    Plugin Author Tobias Bäthge

    (@tobiasbg)

    13 years, 6 months ago

    Hi Jeff,

    thanks for sending me the HTML file! I will now investigate this further and try to find a fix that I will then add to the plugin. I will try to post regularly updates about my progress on this issue in this thread.

    And it’s good to hear that that work around worked 🙂 I just thought of it after you said that WP-Table Reloaded imported your file just fine 🙂

    Regards,
    Tobias

    Plugin Author Tobias Bäthge

    (@tobiasbg)

    13 years, 6 months ago

    Hi Jeff,

    turns out, that I was able to find a fix quicker than I had thought 🙂
    In my tests (also with your table), everything now imported fine, but I would really appreciate it, if you could also test this on your site.
    To do that, please replace the file “classes/class-import.php” in the “tablepress” plugin folder on your site with the file from https://raw.github.com/TobiasBg/TablePress/master/classes/class-import.php

    Thanks again for finding and reporting this bug!

    Regards,
    Tobias

    Thread Starter Jeff Cohan

    (@jdcohan)

    13 years, 6 months ago

    Thanks for the prompt attention and turnaround!

    I replaced the class file and re-tried the HTML import: it worked just fine.

    Great job. Loving the new plugin.

    My next job it to test the WPTR -> TablePress migration.

    Jeff

    Plugin Author Tobias Bäthge

    (@tobiasbg)

    13 years, 6 months ago

    Hi Jeff,

    awesome! Thanks for testing this! 🙂

    About the migration: You shouldn’t have to worry too much. If you aren’t using any special features/extensions/manual adjustments in WP-Table Reloaded, the migration is very easy. The migration guide at http://tablepress.org/migration-from-wp-table-reloaded/ describes the most important steps.

    Best wishes,
    Tobias

    concretetechgroup

    (@concretetechgroup)

    13 years, 3 months ago

    hi,
    i am trying to import a table from csv format (which was originally in excel & converted to csv using save as option).
    When the table is imported data in many cells is not imported (though data is presnt in those cells in csv format file).
    You can see the issue at following URL:
    http://concretebasics.org/duplicatetry/table-press-try/
    (DATA IN SOME CELLS OF ROWS LIKE 11,15,16,23,36,37,39,41-44,46, 48,49,52,53, 55 & 56 is missing).

    You can download corresponding csv file from following url:
    http://www.concretebasics.org/tableimporttrycsvv.zip

    Could you please see whats the issue

    thanks

    Plugin Author Tobias Bäthge

    (@tobiasbg)

    13 years, 3 months ago

    Hi,

    thanks for your post, and sorry for the trouble.

    This is probably related to the character encoding of the CSV file. I’ve added some improvements in handling this in TablePress 0.9-RC, that came out a week ago.
    You are still using 0.8.1-beta, so please update and try the import again.

    Regards,
    Tobias

    concretetechgroup

    (@concretetechgroup)

    13 years, 3 months ago

    hi!
    thanks.
    0.9 RC resolved the issue.
    gr8 work; adding a feature of prescribing column widths in %ages (like websimons) would make it even better.
    Would luv if javaquery options (particularly the search option) works even when cells are merged.
    thanks a lot

    Plugin Author Tobias Bäthge

    (@tobiasbg)

    13 years, 3 months ago

    Hi,

    awesome! Thanks for upgrading. Good to hear that the new version fixed it!

    About your other two suggestions:
    I will not be adding input fields for the column width, as I believe in separation of content and layout. And actually, there’s a much better and more flexible way to set column widths in TablePress. Please take a look at the FAQ entry at https://tablepress.org/faq/column-widths/ With that “Custom CSS” approach, you can set percentage widths as well.
    About the search option for tables with merged cells: I’d love to have this, too, but as this is a limitation of the external JavaScript library that TablePress uses for this, there’s nothing that I can do here at this time 🙁

    Best wishes,
    Tobias

Viewing 10 replies - 1 through 10 (of 10 total)

The topic ‘Import from HTML ignores some code’ is closed to new replies.