!important in style attribute

  • Resolved Sinisa Nikolic

    (@sin2384)


    10 years ago

    Hi fellows,

    great plugin!

    I have one question – why do you use !important in:

    <li class="count-twitter">
    <a class="icon" href="https://twitter.com/user"></a><span class="items"><span class="count" style="color: #dd3333 !important;">30637</span><span class="label" style="color: #dd3333 !important;">followers</span></span>
</li>

    It’s not really necessary as much as I can tell. If theme is done right, there’s no need for adding important, inline style should be enough.

    Trouble is, I can’t style this text with my color cause of this, unless I remove style attribute via Javascript, but that’s dirty.

    Is there any way you could add a filter to disable this rule, or option in plugin?

    Thanks for reading!

    https://ww.wp.xz.cn/plugins/social-count-plus/

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Claudio Sanches

    (@claudiosanches)

    10 years ago

    Because several people had problems with it.

    Trouble is, I can’t style this text with my color cause of this, unless I remove style attribute via Javascript, but that’s dirty.

    You can change the color using the plugin settings.

    Is there any way you could add a filter to disable this rule, or option in plugin?

    Feel free to submit a Pull Request: https://github.com/claudiosmweb/social-count-plus

    Thread Starter Sinisa Nikolic

    (@sin2384)

    10 years ago

    Pull request sent.

    Plugin Author Claudio Sanches

    (@claudiosanches)

    10 years ago

    @sin2384 Update to 3.3.4 now, thanks 🙂

    Thread Starter Sinisa Nikolic

    (@sin2384)

    10 years ago

    Thanks for making changes! Yes, filter is not actually necessary, but if plugin by default set’s own color (can’t test now if it does), than it’s useful to prevent that.

    Anyway, it will work like this.

    Cheers!

    Plugin Author Claudio Sanches

    (@claudiosanches)

    10 years ago

    @sin2384 works fine only salving as empty 🙂

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘!important in style attribute’ is closed to new replies.