Incorrect last star
-
Hi. After last update I have a problem with last star in rating.
If post have rating 4.3-4.9 last star must be use file “rating_half.gif”.
But now last star use file “rating_off.gif”.
-
Hmm I can’t reproduce this problem though
This is 4.6: https://lesterchan.net/wordpress_dev/2018/11/27/poll-id-17/
This is 4.3: https://lesterchan.net/wordpress_dev/2018/11/27/poll-id-16/
This is 4.9: https://lesterchan.net/wordpress_dev/2018/10/16/poll-id-15/
-
This reply was modified 7 years, 5 months ago by
Lester Chan.
Version plugin 1.84.1. http://take.ms/tC58U
Version plugin 1.86.1. http://take.ms/ussYaWordpress is 4.9.9
I am using WordPress 5.0.2, though the version of WP should not matter. Since I can’t reproduce it, I will wait to see if there are more ppl facing the same problem.
I have the same problem too, in WordPress 4.9.9.
https://drive.google.com/file/d/1mcJQ0iRtv4fLBfCjs2nYCt_Wq1AbLSqM/view
Here is the post where I tried it
However, I am having the same problem on one of my other sites with WordPress 5.0.2
https://www.pcsteps.com/630-create-a-windows-installation-disc-or-usb/
-
This reply was modified 7 years, 5 months ago by
Angelos Kyritsis.
@angelos-kyritsis Weird, I copied the stats of https://www.pcsteps.com/630-create-a-windows-installation-disc-or-usb/ to
https://lesterchan.net/wordpress_dev/2018/11/27/poll-id-17/It is fine.
-
This reply was modified 7 years, 5 months ago by
Lester Chan.
Well, maybe there is a problem with the Genesis Framework? Because I also have the problem in a smaller site https://www.websloth.gr/1114-%CE%BD%CE%AD%CE%B5%CF%82-%CE%B5%CE%BE%CE%B5%CE%BB%CE%AF%CE%BE%CE%B5%CE%B9%CF%82-%CF%83%CF%84%CE%B7%CE%BD-%CE%BF%CE%B9%CE%BA%CE%AF%CE%B1-%CF%84%CE%BF%CF%85-%CE%B8%CE%B5%CE%BF%CF%8D/ and I have disabled every other plugin, to no avail. The only thing in common is the Genesis Framework and the child theme.
The thing is I don’t see how a theme or WP or other plugins is affecting this since the stats are calculated on the PostRatings side.
Are you able to set up a fresh install of WP with just WP-PostRatings on the same server may be in another folder to see if the issues persist?
The other thing I am thinking of is caching. On my dev/test site, they are no caching plugins.
PCsteps.gr and Websloth.gr are on the same server, PCsteps.com is in a separate server. Also, on Websloth.gr I disabled all caching, and it didn’t make a difference.
Can you provide a copy of the previous version, and point out the changes in the code? I can run some tests to see which of the changes is breaking the latest version.
I even changed temporarily Websloth.gr to the 2019 WordPress theme, and I am still getting the same error.
Same issue here. On my test site which is a mirror of my live site, the rating of a post is 3.25 but it shows 3 full stars. On my live site, that exact same post with a rating of 3.25 shows 3 and a half stars. No caching on either site and I’m on the latest WordPress.
Checking all my posts on my test site and it seems the latest update is not showing any half star images.
Just wondering what PHP version are you all using?
@angelos-kyritsis Checking for 1/2 stars https://github.com/lesterchan/wp-postratings/blob/master/wp-postratings.php#L1122-L1129
Thanks for your help!
I finally found the problem. It is a double vs int. I am moving towards more of a strict check
This is the commit that should fix it https://github.com/lesterchan/wp-postratings/commit/6a81f08aa4348e45d48126cfb66fe61f49aa2a0f
For the less technical, just replace wp-postratings.php with the contents of https://raw.githubusercontent.com/lesterchan/wp-postratings/master/wp-postratings.php.
Once you guys have verified, I will push an update.
-
This reply was modified 7 years, 5 months ago by
The topic ‘Incorrect last star’ is closed to new replies.