Inline CSS joke

  • Resolved Ivaseg

    (@ivaseg)


    7 years, 2 months ago

    <em style="color: #FF9140;">73 <small>downloads</small></em>
    Omg, man! Why do you use inline style here? You can easily do the same in much better way:
    .mdocs-downloads em {color: #ff9140}
    Now I must use !important to rewrite this your inline style 🙁

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author bhaldie

    (@bhaldie)

    7 years, 2 months ago

    mdocs-show-file-info-template.php line 136:

    
mdocs_update_file_info('show-downloads', array('color' =>  '#FF9140'));
    Plugin Author bhaldie

    (@bhaldie)

    7 years, 2 months ago

    or you can create you create your own file in the plugins folder and overwrite whatever you want:

    ivaseg-file.php

    inside file:

    
<?php
// ADD THE ACTION HOOK WP LOADED TO REGISTER THE NEW FILE INFO
add_action('wp_loaded','ivaseg_file');
// THE FUNCTION TIED TO THE HOOK
function ivaseg_file() {
    mdocs_update_file_info('show-downloads', array('color' =>  'some random color of you choice'));
}
    • This reply was modified 7 years, 2 months ago by bhaldie.
    Thread Starter Ivaseg

    (@ivaseg)

    7 years, 2 months ago

    Inline styles are not best practice. It’s not difficult to you to move this code to some style.css file, but instead you ask users to create them php files to override your settings. and each time we must do this. Ok, if you think you doing in right way – ok, never mind, it’s your plugin and your choice.

    Plugin Author bhaldie

    (@bhaldie)

    7 years, 2 months ago

    the plugin folder is never deleted once you have created the file it will never be removed.

    Do it or not its up to you.

    this plugin folder will allow users in the future to create their own columns with me having to deal with it.

    Thread Starter Ivaseg

    (@ivaseg)

    7 years, 2 months ago

    I heard you. But, it seems we are from different worlds. Previously I had some ideas, but now I see that this is just useless time spending) Just forget it.
    In any case – thanks for the wonderful plugin!

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Inline CSS joke’ is closed to new replies.