Inline ""wpfp-dynamic-css" style, Themeforest soft-reject

  • Resolved Ivan911

    (@ivan911)


    9 years, 11 months ago

    I got soft-rejected on Themeforest, one of the reasons is inline css.

    In footer of our theme there is inline style with “wpfp-dynamic-css” id. Do you have any recommendation how to add this style using wp_add_inline_style?

    Quoting Themeforest review team :
    “Scripts and styles should not be hardcoded anywhere in your theme or added any other way but with wp_enqueue_* hook and to be added from the functions file. This includes custom JS/CSS.”

    Best Regards,
    Ivan

    https://ww.wp.xz.cn/plugins/wp-fullpage/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Julien Zerbib

    (@julien-zerbib)

    9 years, 8 months ago

    Hi Ivan,

    The last release should fix the issue.

    As a matter of fact, dynamic css is now added like this :
    <script type="text/template" id="wpfp-dynamic-css"><?php print WPFP_Helpers()->get_dynamic_css(); ?></script>

    The content of the template is added on dom ready to a style markup in the header by javascript before fullpage is built…

    Let me know if it does the trick ! 🙂

    Regards,

    Julien

    Thread Starter Ivan911

    (@ivan911)

    9 years, 7 months ago

    It worked like charm!

    Thank you,

    Regards, Ivan

    Plugin Author Julien Zerbib

    (@julien-zerbib)

    9 years, 7 months ago

    Hi Ivan,

    Nice to read !!

    Thanks for your reply 🙂

    Best,

    Julien

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Inline ""wpfp-dynamic-css" style, Themeforest soft-reject’ is closed to new replies.