@frumph , sorry I made an error before:
">Comments(0) this is part of your plug-in, but was displayed wrongly because of those filters.
@atardiff
are you talking about those in the featured pages? Are those normal pages?
I have to try this plug-in .. I’ll let you know if I find a solution
Yes, the text that says “>Characters in the round picture window shouldn’t be there. Also, the button beneath should say “Read more,” not “Characters” again with “>Read more » next to it.
The featured pages were created by just creating normal pages from within WordPress and then telling the theme via the customizer to use them as featured pages.
Any luck on getting that extra text to disappear again?
That’s another case of the filter re-writing some plugins title=”” tag inside of the href ..
that one has nothing to do with ‘comic’ at all, it’s just an adjustment in their filter code to omit title= from being filtered is necessary as a whole
https://github.com/Nikeo/customizr/issues/47
Posted an issue on the theme dev’s github page about it.
Hi @frumph
Ok that customizr part retrieves the title using get_the_title(PAGE_ID), and, as said before, customizr has some filters on the title, but..
Customizr doesn’t apply those filters on the title if you’re not in the loop:
https://github.com/Nikeo/customizr/blob/master/inc/parts/class-content-headings.php#L165
https://github.com/Nikeo/customizr/blob/master/inc/parts/class-content-headings.php#L192
https://github.com/Nikeo/customizr/blob/master/inc/parts/class-content-headings.php#L235
So without your plugin (or better, without using this code: https://ww.wp.xz.cn/support/topic/integrating-comic-easel-plugin?replies=19#post-6487908 ) you don’t have that issue on featured pages, ’cause they’re outside the wordpress the_loop. So what in your plugin makes those conditions fail? Why they “see” they’re in_the_loop when they aren’t?
Except his latest read more bug that he has has nothing to do with comic easel.
What?
I told you that this was necessary because of customizr filters, and has to do with compatibility, and if you want you can call it customizr bug/wrong behavior.
What I’m asking is, why adding this
<?php do_action('comic-area'); ?>
<?php do_action('comic-blog-area'); ?>
before the main container, then before the featured pages (where you can see the read more bug), the check
the condition in_the_loop() returns true?
Without those two lines it doesn’t happen, and it’s normal.
https://github.com/Frumph/comic-easel/commit/0c84fdfe9b9f5864e44e146b842b78f4da4ad581
This should help by tagging the query as not being in the loop, need to test what ramifications it has on the function calls throughout the whole though.
If i’m reading you correctly.
Yes, but the error he has right now has nothing to do with comic easel.
Just so you can recognize that. the read more on his links on his page that appear after the actual button are bad filters.
http://johnargentcomic.com
..which are now gone for some reason, guess he commented out those lines I told him to? need response.
Ah I see you force the $wp_query var .. well I think you can revert it back after your loop, isn’t it?
Yeah it does a wp_reset_query afterwards the problem now is that i would need to find out if that will make it generate a larger overhead, but shouldn’t be that much of a big deal.
What I just now did was delete
do_action(‘comic-blog-area’);
from the index.php — it was on a line right after
“do_action(‘comic-area’);”
— and use the widget tool in the customizer to add the blog section underneath the comic. Suddenly everything looks right! Which leads to to wonder if I just did the integration with Comic Easel wrong?
Yes, but the error he has right now has nothing to do with comic easel.
Just so you can recognize that. the read more on his links on his page that appear after the actual button are bad filters.
Of course his problem with the read more (and also with the link which wraps the rounded thumbnails) has to do with those customizr filters. What I was saying is that because of that “in_the_loop” forced to true, customizr “thought” to be in the loop and applied those filters, when he shouldn’t and he doesn’t generally (when not using your plugin in that page). And, by the way, appliyng your latest commit, works.
