Internationalization Issues

  • Resolved Alex Lion (阿力獅)

    (@alexclassroom)


    3 years, 8 months ago

    Hi,

    I found several I18N issues, I listed the reason and the modified code as the following.

    Reason:
    This plugin’s slug is bubuku-media-library, but the current Text Domain is bbkmedialibrary. Change the current Text Domain so it is equal to this plugin’s slug and modify the text domain in all your source files. This change is **needed**, please refer to this article.

    Modified Code:
    bubuku-media-library.php, Line 10
    Corrected: * Text Domain: bubuku-media-library

    src\BML_view.php, Line 64, 66, 72, 96
    src\BML_restapi.php, Line 52
    src\BML_filter.php, Line 43, 47, 51, 70, 74, 78, 82
    src\BML_common.php, Line 50
    Change text domain from bbkmedialibrary to bubuku-media-library.

    src\BML_common.php, Line 34
    Corrected: $columns['bk_file_size'] = __( 'File Size', 'bubuku-media-library' );

Viewing 3 replies - 1 through 3 (of 3 total)
  • Thread Starter Alex Lion (阿力獅)

    (@alexclassroom)

    3 years, 8 months ago

    If this plugin’s GitHub repository is private, please make it public like your other plugins so I can submit a pull request.

    Plugin Author Luis Ruiz

    (@lruizcode)

    3 years, 7 months ago

    Thanks, Alex, for spotting it.

    In the next update, I will correct it, I had thought to put the public repository later when it had more functionalities.

    I’ll think about if I make it public in the next update, thanks a lot for your help.

    Plugin Author Luis Ruiz

    (@lruizcode)

    3 years, 6 months ago

    I just released version 1.0.3 which fixes the problem and added the Bulk action to it from the list.

    Thank you very much, Alex, for the warning.

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Internationalization Issues’ is closed to new replies.