Hi @clt00,
Glad you reached out.
The issue here is most likely related to Donations (likely very old ones) that have somehow become detached from their donation form in the database. From your error message, I see that it’s currently hung up on donation #3934. You should be seeing a Form ID with the form’s title, and a donation amount, but both of those are showing as “0”.
The slightly boring technical explanation of what’s going on there: the update routine in question has to do with moving old donations that were made before GiveWP had a concept of “revenue” into the new revenue database table. In order to add donations to the revenue table, it needs a donation ID, Form ID, and amount. If any single donation on the site does not have one of those three things, the updater stops and logs the error.
The fastest way around it is what you mentioned, deleting the offending donations. Unfortunately, it stops on the first one it finds and doesn’t tell you about any others of them, so you have to comb through all the donations and find ones that are detached from their form.
It would be a bit tedious to find a donation, delete it, restart database updates, look at the logs to see if there are more donation errors, and repeat. Below is a screencast of how I search sites for donations that are detached from forms. Usually there are multiple forms in a site, so essentially the screencast is of me sorting by form name, reverse alphabetically, to see if I can surface any donation that has the form name as Untitled.
Here’s the screencast: https://somup.com/c3Qv2QUNJC
Alternatively, the donations in question are often the oldest donations, so sometimes viewing the last page of donations will show you the donations that need to be addressed.
You don’t have to delete those donations, but the workaround is to go into each donation individual and reattach a form. This can get become tedious really fast, and there’s no way to bulk edit donations for this task.
How do donations become detached from a donation form? The vast majority of the time it is because a form has been deleted, so the donation doesn’t have a form to be attached.
Let me know if you have questions about this, I’m happy to help.
