Issue on order-pay endpoint

Hi George

thanks for looking into this.
To replicate the issue you have to test first that the /checkout/order-pay/ endpoint is working correctly (so a page is shown, even if blank). Then:

• change the permalink structure from %postname% to another one
• save changes
• change back to %postname%
• save changes

The endpoint “order-pay” should not be available anymore (a not found page should be shown).
Then, if you save changes in the “wp-admin/admin.php?page=wc-settings&tab=checkout” page, the endpoint order-pay should be working again because the permalink structure is flushed.

Let me know if you can reproduce this issue.

Yep, probably the site (which is not mine) has some other configurations which makes difficult to reproduce the issue.
Anyway I saw this problem also on another website (which, again, is not mine) so my solution

if ( empty(WC()->query->query_vars['order-pay']) ) {
    WC()->query->init_query_vars();
    WC()->query->add_endpoints();
    flush_rewrite_rules();
}

can be useful to someone.

Anyway, thank you for your time

Hi costas90

you can attach the code to the woocommerce_checkout_init action.
So adding this code:

add_action('woocommerce_checkout_init', 'yourthemename_woocommerce_checkout_init' );
function yourthemename_woocommerce_checkout_init() {
  if ( empty(WC()->query->query_vars['order-pay']) ) {
    WC()->query->init_query_vars();
    WC()->query->add_endpoints();
    flush_rewrite_rules();
  }
}

into your functions.php file (this file is under the theme folder), should be fine.

Great! 😉

It can be placed anywhere on the file.

For a more in deep explanation of actions and filters please read this great article.

I’m not really sure if it can be this the problem.
Under class WCML_Endpoints,

function register_endpoints_translations(){

        if( !class_exists( 'woocommerce' ) || !defined( 'ICL_SITEPRESS_VERSION' ) || ICL_PLUGIN_INACTIVE || version_compare( WOOCOMMERCE_VERSION, '2.2', '<' ) ) return false;

        $wc_vars = WC()->query->query_vars; // (1)

        if ( !empty( $wc_vars ) ){
            $query_vars = array(
                // Checkout actions
                'order-pay'          => $this->get_endpoint_translation( 'order-pay', $wc_vars['order-pay'] ), // (2)
                'order-received'     => $this->get_endpoint_translation( 'order-received', $wc_vars['order-received'] ), // (3)

...

on (1) $wc_vars[‘order-pay’] is set to “order-pay”, but on (2) it looses its value. On (3) the value is present.

I really don’t know why this happens but it is so.

ok thanks