• Resolved tunyafix

    (@tunyafix)


    Hi I found an issue on add_group_user, basically the variable $data is overwritten on update, then if you have a new insert fails

    The error is produced on https://plugins.trac.ww.wp.xz.cn/browser/press-permit-core/trunk/admin/groups-update_pp.php#L33

    I add diff

    Index: wp-content/plugins/press-permit-core/admin/groups-update_pp.php
    IDEA additional info:
    Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
    <+>UTF-8
    ===================================================================
    --- wp-content/plugins/press-permit-core/admin/groups-update_pp.php	(revision 5df99332a5f0d85a57973867d3a8591ea863f76a)
    +++ wp-content/plugins/press-permit-core/admin/groups-update_pp.php	(date 1552117235000)
    @@ -41,8 +41,8 @@
     			$data['user_id'] = $user_id;
     			
     			if ( $already_member = $wpdb->get_col( $wpdb->prepare( "SELECT user_id FROM $members_table WHERE group_id = %d AND user_id = %d", $group_id, $user_id ) ) ) {
    -				$data = array( 'status' => $status );
    -				$wpdb->update( $members_table, $data, array( 'group_id' => $group_id, 'user_id' => $user_id ) );
    +				$dataUpdate = array( 'status' => $status );
    +				$wpdb->update( $members_table, $dataUpdate, array( 'group_id' => $group_id, 'user_id' => $user_id ) );
     			} else {
     				$data['add_date_gmt'] = current_time( 'mysql', 1 );
     				$wpdb->insert( $members_table, $data );
    

    Best regards

Viewing 1 replies (of 1 total)
Viewing 1 replies (of 1 total)

The topic ‘Issue on press-permit-core/admin/groups-update_pp.php’ is closed to new replies.