Issue with oembed replacement function in 2.2.1

MetalMusicMan
(@metalmusicman)

10 years, 8 months ago
I use a function in my functions.php to put a wrapper around my Featured Videos, so I can make them responsive. Here’s the code I use:
```
// Wrap a div around embedded videos
add_filter('embed_oembed_html', 'my_embed_oembed_html', 99, 4);
function my_embed_oembed_html($html, $url, $attr, $post_id) {
  return '<div class="video-container">' . $html . '</div>';
}
```
I then use CSS to control the “video-container” class.

However, if I upgrade to 2.2.1 or 2.2.2, it breaks my function.

Any idea why this happens?

https://ww.wp.xz.cn/plugins/featured-video-plus/

Viewing 4 replies - 1 through 4 (of 4 total)

Plugin Author Alex
(@ahoereth)

10 years, 8 months ago

The videos are wrapped in a .featured-video-plus div – why don’t you simply target that one in your css? And does the responsive sizing feature integrated into the plugin not work? What CSS rules are you using?
Thread Starter MetalMusicMan
(@metalmusicman)

10 years, 8 months ago
Actually, regarding the wrapper, you’re right. That wrapper CSS is actually for another section and I confused them. I use that CSS for general embedded videos, but not for the featured ones.

However, that makes the original issue even more confusing to me. I have no idea what is breaking the responsiveness now. All I know is that it is working on 2.2.0, and as soon as I upgrade to 2.2.1 or 2.2.2, the video no longer shrinks to fit my existing div.

The container div I use for all featured images / videos has the following CSS:
```
display: inherit;
    overflow: hidden;
    float: right;
    width: 30vw;
    max-width: 460px;
    height: inherit;
    max-height: 250px;
    margin: 0em 1px 1em 1em;
    outline: 1px solid #c3c3c3;
    border: 6px solid #f7f7f7;
    border-bottom: 12px solid #f7f7f7;
    box-shadow: 0px 4px 0px #c3c3c3;
```
I use conditionals to change the max width and max height based on screen resolution of the client.

Did you change any class or ID names in 2.2.1 or 2.2.2? I’m trying to figure out what is different in the versions that would be causing this.
Plugin Author Alex
(@ahoereth)

10 years, 8 months ago

You can check out the diff here – I don’t think I did change any relevant ids or class names. Do you have a link to the website with this issue?

Thread Starter MetalMusicMan
(@metalmusicman)

10 years, 8 months ago

Here you go: http://tinyurl.com/q9admpx

When I upgrade above 2.2.0, the video no longer fits the containing div. It doesn’t break the box, but it stretches to be larger than the div can show, therefor the user can’t see any of the controls or the full video unless they double-click for full screen.

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Issue with oembed replacement function in 2.2.1’ is closed to new replies.