Issue with url parameters for admins

Resolved johannesdb
(@johannesdb)

2 years, 1 month ago

Hi

my issue is that when logged in as admin, url query parameters are changed.

For example this url: https://dmiskills.dk/dit-program/?konkurrence=?1.show-favorites=true

Becomes this: https://dmiskills.dk/dit-program/?konkurrence=?1_show-favorites=true

If the url contains a query parameter with an array of values like this: posts=14,15,16 – the commas are url encoded.

This only happens when logged in as admin. But it breaks functionality on my site and makes it kinda hard to navigate the site as admin.

Is there a way to prevent the url changes?

The page I need help with: [log in to see the link]

Viewing 14 replies - 1 through 14 (of 14 total)

Plugin Author Jory Hogeveen
(@keraweb)

2 years, 1 month ago

Hi @johannesdb

Before I dive into this, are you sure this problem is related to this plugin? Does the same thing happen when all other plugins are deactivated and you are running on a default theme?

I ask this because this plugin doesn’t modify the URL, it only registers a few plugin related keys for auto-removal which is handled by WordPress core.

Cheers, Jory
Thread Starter johannesdb
(@johannesdb)

2 years, 1 month ago
Hi @keraweb,

Thanks for the fast answer!

I have tried to disable only this plugin and then the urls are not changed. I can’t say if it interacts with another plugin on the site and that is the issue. But disabling the view as plugin always solves the issue.

If you want, send me mail to get access to a site where you can see the issue.

/Johannes
- This reply was modified 2 years, 1 month ago by johannesdb.
Plugin Author Jory Hogeveen
(@keraweb)

2 years, 1 month ago

Hi @johannesdb

Just a quick test before and further debugging since I have an idea what would be the cause.

Could you disable this line? https://github.com/JoryHogeveen/view-admin-as/blob/master/ui/class-ui.php#L56

You can just comment it and it should be fine. (add “//” before it).
Let me know if this changes anything!

Cheers, Jory

Thread Starter johannesdb
(@johannesdb)

2 years, 1 month ago

Hi @keraweb,

sure! Just tried – no change :-/
Thread Starter johannesdb
(@johannesdb)

2 years, 1 month ago
However this is the culprit!
```
    /**
     * Compat with front and WP version lower than 4.2.0.
     * @since  1.6.4
     * @link   https://developer.ww.wp.xz.cn/reference/functions/wp_admin_canonical_url/
     */
    if ( ! is_admin() || ! VAA_API::validate_wp_version( '4.2' ) ) {
    //  $this->add_action( 'wp_head', array( $this, 'remove_query_args' ) );
    }
```
When I uncomment that line, the url is not changed 🙂
Plugin Author Jory Hogeveen
(@keraweb)

2 years, 1 month ago
Hi @johannesdb

You are absolutely right, this method is also run on the front-end since the default WordPress core handler only runs on the admin.

I’ve added a path to the next dev version that only runs this code if there is an actual removable get variable present in the URL (for reset purposes etc.)

Patch: https://github.com/JoryHogeveen/view-admin-as/commit/09be711b739ae205d8322c04b6347231283b60df

PR: https://github.com/JoryHogeveen/view-admin-as/pull/131

Let me know if this works for you!

Edit: Just sideinfo, it appears that your URL structure isn’t compatible with WP core query methods (in this case remove_query_arg or maybe esc_url).

Cheers, Jory
- This reply was modified 2 years, 1 month ago by Jory Hogeveen. Reason: Sideinfo
Thread Starter johannesdb
(@johannesdb)

2 years, 1 month ago

Hey @keraweb

cool! Thanks for the patch!

Yup, we are aware that our urls are not quite compatible with wordpress. But they are with the js-library that we use. And there are no good ways to make wordpress compatible urls, that contains arrays. So it is a trade off.

Do you know when the next release will be out?

Plugin Author Jory Hogeveen
(@keraweb)

2 years, 1 month ago

Hi @johannesdb

Perfect, could you please confirm whether the patch works for you or not? If so, I will release a.s.a.p.!

Cheers, Jory

Thread Starter johannesdb
(@johannesdb)

2 years, 1 month ago

Hey @keraweb

sure 🙂 Tested and the patch works 😀

Plugin Author Jory Hogeveen
(@keraweb)

2 years, 1 month ago

Awesome, since it’s almost weekend I’ve scheduled the release for next week 🙂

Cheers, Jory

Plugin Author Jory Hogeveen
(@keraweb)

2 years, 1 month ago

Hi @johannesdb

Just a heads-up. The release has a bit of a delay as I’m trying to get unit tests up and running.
Rest assured that the nest release will include this patch anyway so your local patch will be fine in any case!

Cheers, Jory

Thread Starter johannesdb
(@johannesdb)

2 years ago

Hi @keraweb

Just wanted to hear if there is any news about the update?

/Johannes

Plugin Author Jory Hogeveen
(@keraweb)

2 years ago

Hi @johannesdb

Thanks for the reminder, I’ve been absolutely swamped with work.
The release has been published just now!

Cheers, Jory

Thread Starter johannesdb
(@johannesdb)

2 years ago

@keraweb best news for a weekend! Thanks! 🙂

hope you Will and can have a lovely weekend!

Viewing 14 replies - 1 through 14 (of 14 total)

The topic ‘Issue with url parameters for admins’ is closed to new replies.