Hi,
You are correct, we made some changes regarding this in v2.4.2 (v2.4.1 should work the same as v2.4.0 though). We disabled price formatting and any conversions made on shop’s default currency, as some of our customers complained that price in shop’s default currency being unexpectedly rounded etc.
Regarding “… primary shop currency no longer shows currency type…” – this one I missed, will be fixing right now, update will be available in a couple of hours max.
Regarding “…Pretty Price does not work for default shop currency…” – this one I’m not sure if we should add it back to the plugin, as you are setting price for products in default currency manually by yourself, so why just not set it to “pretty price” directly? Does the plugin really needs to make any default currency price adjustments here? I could add this add some “advanced option” though. Please let me know what you think.
Best regards,
Tom
Thread Starter
xolite
(@xolite)
I definitely agree with primary currency being set on our own for .99 etc, very true. So you are saying conversions will round and use “Pretty” price as part of the conversion. Makes sense.
On my end when I tested 2.4.2 ( 2.4.1 ) the first product if sorted by “ASC” still showed Pretty Price and the rest did not. ( will double check )
I do also want to mention, $0.00 mini-cart values are not switched, example if “WC()->cart->get_cart_total();” is used in a theme, the default currency will always be shown when switched. Example $0.00 CAD if the switcher is used, it remains as CAD.
Thank you again Tom, hope all is well.
Hi again,
Thanks for feedback – will check that get_cart_total() issue.
I’ve just released v2.4.3:
1. Now you can add currency symbol to shop’s default currency as well (in “WooCommerce > Settings > Currency Switcher > Price Formats”).
2. In case anyone still needs this – I’ve added “Apply Rounding and Pretty Price to Shop’s Default Currency” option to “Advanced Options” in “WooCommerce > Settings > Currency Switcher > General”.
Hope I didn’t mess up anything – please let me know if it’s working correctly.
Best regards,
Tom
Thread Starter
xolite
(@xolite)
Hi Tom,
Giving it a run through in a few minutes here and will let you know.
All the best,
Rick
Thread Starter
xolite
(@xolite)
Full test everything looks good. Did you find anything regarding conversion on WC()->cart->get_cart_total(); when the cart is empty on $0.00 total?
I do not imagine it really matters except for those who show
the cart in the header:
2 Items $35.55 CAD ( this does convert )
0 Items $0.00 CAD
( this does not convert or I should change currency codes if the currency is switched )
Looks odd is all to stay in the default currency when everything else switches to USD lol.
All the best,
Rick
Hi Rick,
Unfortunately didn’t have time to check it yet – will do asap. By the way – there is “Fix Mini Cart” checkbox in plugin’s “General” settings (“Advanced Options” section) – do you have it enabled? I’m not sure it will fix it though, just a thought…
Best regards,
Tom
Thread Starter
xolite
(@xolite)
Hi Tom,
Yes “Fix Mini Cart” option is checked, but does not affect $0.00 value.
Hope you are having a good day!
All the best,
Rick
Hi Rick,
I’ve played today a little with WC()->cart->get_cart_total() but unfortunately couldn’t reproduce the issue. I’ve added it to my Storefront Child theme, but it seems to be working fine for me: currency symbol is changing as it should be (I’ve tried with both empty cart and not empty cart).
Best regards,
Tom
