Issues with output buffer handling

  • Resolved Albert Peschar

    (@kiboit)


    6 years, 5 months ago

    Hi there,

    Your usage of rocket_buffer hook seems to break other plugins that do stuff using ob_start callbacks, such as my optimization plugin PhastPress.

    I believe should implement your rocket_buffer and ob_start handlers to simply return the processed output, and not call ob_get_clean. You don’t need ob_get_clean because after your ob_start is called the output buffer will be closed automatically.

    –Albert

Viewing 2 replies - 1 through 2 (of 2 total)
  • Thread Starter Albert Peschar

    (@kiboit)

    6 years, 5 months ago

    For those that are affected by this issue, comment out this line in squirrly-seo/controllers/Frontend.php:

    add_filter('rocket_buffer', array($this->model, 'getBuffer'), PHP_INT_MAX);

    This should be on or around line 70.

    Plugin Contributor Calin Vingan

    (@calinvingan)

    6 years, 5 months ago

    Thank you Albert for your feedback.
    We will test again that hook with the last version of Wp-Rocket and remove it if it’s not needed.

    Best, Calin

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘Issues with output buffer handling’ is closed to new replies.

Tags