JavaScript error in v2.6.1

Resolved James Nylen
(@jnylen0)

4 years, 9 months ago

Hi,

Version 2.6.1 of this plugin is causing a JavaScript error in core when using the classic editor.

As part of the series metabox, this plugin creates a div with class categorydiv which is a special class used by core: https://github.com/WordPress/wordpress-develop/blob/b83b01e1b01429dc4a6da49ec23e1f7dfc4ae446/src/js/_enqueues/admin/post.js#L569-L571

The div is created by the plugin here: https://plugins.trac.ww.wp.xz.cn/browser/organize-series/tags/2.6.1/orgSeries-admin.php#L288

Core’s JavaScript in post.js linked above does not expect this categorydiv class to be present anywhere except for in core’s category selector metabox. This plugin creates a div that breaks this core JavaScript code with an error “this_id is undefined”. This causes a cascading failure that stops much of the JavaScript execution on the editor page.

Removing the categorydiv class from this div seems to fix this error. I also see that the plugin code in trunk is different from what was released in 2.6.1 though, so I’m not sure if you had another fix in mind for this issue that didn’t make it into the 2.6.1 release.

Viewing 2 replies - 1 through 2 (of 2 total)

Plugin Author

Steve Burge

(@stevejburge)

4 years, 9 months ago

Thanks for the detailed report @jnylen0

We’ll fix in 2.6.2
https://github.com/publishpress/publishpress-series/issues/213

Thread Starter

James Nylen

(@jnylen0)

4 years, 9 months ago

You’re welcome.

In the meantime, users can add the following code to functions.php or a mu-plugin to fix the issue:

// Fix for https://ww.wp.xz.cn/support/topic/javascript-error-in-v2-6-1/

add_action('add_meta_boxes', function() {
  global $wp_meta_boxes;
  $wp_meta_boxes['post']['side']['default']['seriesdiv']['callback'] =
    'series_edit_meta_box_fixed';
}, 10);

function series_edit_meta_box_fixed() {
  ob_start();
  series_edit_meta_box();
  $html = ob_get_clean();
  echo str_replace(
    '<div class="series-metadiv categorydiv">',
    '<div class="series-metadiv">',
    $html
  );
}

This reply was modified 4 years, 9 months ago by James Nylen.
This reply was modified 4 years, 9 months ago by James Nylen.

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘JavaScript error in v2.6.1’ is closed to new replies.