Jetpack breaks Leaflet Maps Marker plugin

Resolved Robert Seyfriedsberger
(@harmr)

13 years, 5 months ago

If you use Jetpack 2.0.4 together with my plugin Leaflet Maps Marker (v3.2.4 – http://downloads.wp.xz.cn/plugin/leaflet-maps-marker.3.2.4.zip), my maps get broken after the first connect to the wordpress account within Jetpack.

I dont know what exactly happens within Jetpack, just as I look into the html source afterwards, I see the output of my global $lmmjs_out variable duplicated or sometimes even more often available. If I disconnect from WordPress account, output is normal again.

I will implement a workaround for 3.2.5 but hope that someone from Automatic can take a look into this and see whats going on here. I´d be glad to help of course.
best regards,

Robert

http://ww.wp.xz.cn/extend/plugins/jetpack/

Viewing 7 replies - 1 through 7 (of 7 total)

Thread Starter Robert Seyfriedsberger
(@harmr)

13 years, 4 months ago

Hi,
unfortunately still no response from you – the error exists even with the latest update of Jetpack – please take a look into this issue – I´d be glad to help if you have any questions!
thanks
Robert

Plugin Contributor Christopher Finke
(@cfinke)

13 years, 4 months ago

Hi Robert, I’m confirming that I can reproduce the problem with Leaflet Maps Marker 3.2.4 and the latest Jetpack, and that it goes away when the Publicize module is disabled. I’ll work on a fix.

Thread Starter Robert Seyfriedsberger
(@harmr)

13 years, 4 months ago

thanks!

Thread Starter Robert Seyfriedsberger
(@harmr)

13 years, 3 months ago

Hi,
unfortunately, this bug is still not fixed with the latest version – any news when a fix will be available?
thx,
Robert

Plugin Author Jeremy Herve
(@jeherve)

Jetpack Mechanic 🚀

13 years, 3 months ago

Robert,

The problem seems to be linked with the way your plugin handles shortcodes.

A similar problem was reported in the NextGen plugin:
http://ww.wp.xz.cn/support/topic/jetpack-204-breaks-nextgen-galleries/page/2?replies=38#post-3675708

You can find details about it in this WP-Hackers thread:
http://lists.automattic.com/pipermail/wp-hackers/2013-January/045053.html

Could you try to update your plugin based on Otto’s recommendations?

Thread Starter Robert Seyfriedsberger
(@harmr)

13 years, 3 months ago

Hi Jeremy,

thanks for taking a look into this issue. I studied the posts you linked to and tried to fix it.
Unfortunately with no success :-/

In leaflet-maps-marker.php within the function lmm_frontend_enqueue_stylesheets()
I use
global $wp_query, $wp_version; $posts = $wp_query->posts;

which from my understanding according to Otto should be the reason for this bug. I also talked to Ian Dunn who reported this problem and also thought that his case seems to be different.

But even if I completely remove this code/css check the js output still gets duplicated. So as there
is no other code/function within my plugin which uses $posts I wonder if this really is the
reason for this bug.

Any help would be really appreciated!
thanks,

Robert

Thread Starter Robert Seyfriedsberger
(@harmr)

13 years, 3 months ago

bug got fixed with latest Jetpack release v2.2