Last Modified dates are invalid

ownerstorefly
(@ownerstorefly)

3 years, 6 months ago
OK, if lastmod is enabled (which mine ISN’T anymore) it produces dates that are invalid.

But, there is yet another issue.. If the post does NOT have a date, this plugin will falsely add a CLOSING “<lastmod/>” WITHOUT an initial “<lastmod>”! See the below for just “https://storefly.com”

ALSO, speaking of the above, why on earth is this plugin picking up my top level domain?

There needs to be a way of excluding stuff like this.

Can we please get this fixed? I have you a 5 star review.

Mike

<url><loc>https://storefly.com/return-policy/</loc><lastmod>2022-05-11T16:22:26-07:00</lastmod></url>
<url><loc>https://storefly.com/</loc><lastmod/></url> ***BAD***
<url><loc>https://storefly.com/shipping-info/</loc><lastmod>2022-09-25T12:12:25-07:00</lastmod></url>
<url><loc>https://storefly.com/about/</loc><lastmod>2022-11-21T10:36:54-07:00</lastmod></url>

Via: https://www.inspyder.com/free/SitemapValidator.aspx

Validator Results
Errors were detected in your Sitemap. Your Sitemap is NOT valid!
The following errors were detected in your Sitemap file:
Error(s) Sitemap File Line # Position #
The ‘http://www.sitemaps.org/schemas/sitemap/0.9:lastmod’ element is invalid – The value ” is invalid according to its datatype ‘http://www.sitemaps.org/schemas/sitemap/0.9:tLastmod’ – The value ” is not valid according to any of the memberTypes of the union. wp-sitemap-posts-page-1.xml 3 2380
The ‘http://www.sitemaps.org/schemas/sitemap/0.9:lastmod’ element is invalid – The value ” is invalid according to its datatype ‘http://www.sitemaps.org/schemas/sitemap/0.9:tLastmod’ – The value ” is not valid according to any of the memberTypes of the union. wp-sitemap-taxonomies-pwb-brand-1.xml

Even Google complains….
```
Sitemap can be read, but has errors
Invalid date
2 instances
An invalid date was found. Please fix the date or formatting before resubmitting.
Examples
Line 3
Parent tag:
url
Tag:
lastmod
Line 3
Parent tag:
url
Tag:
lastmod
```
The page I need help with: [log in to see the link]

Viewing 10 replies - 1 through 10 (of 10 total)

Plugin Author Rolf Allard van Hagen
(@ravanh)

3 years, 6 months ago

Hi @ownerstorefly thanks for the review 🙂

Since then, the plugin has not been updated so if something changed, it must be coming from a conflict with either the latest WP version or another plugin. I’ll quickly run a test on WP 6.1 to see if I can reproduce the errors.

In the meantime, a quick question: are you using a cache plugin? I see in the response headers wpo-cache-status: cached (is that WP Optimize?) for the sitemap which might explain lingering errors after changing plugin settings…

Plugin Author Rolf Allard van Hagen
(@ravanh)

3 years, 6 months ago

Just tested on WP 6.1.1 and found no issues. Can you tell me more about your setup?

ALSO, speaking of the above, why on earth is this plugin picking up my top level domain?

I don’t understand the question. The plugin does not handle or modify the domain in any way… What do you see happening which should not happen?

Plugin Author Rolf Allard van Hagen
(@ravanh)

3 years, 6 months ago

About the empty lastmod tags: can you tell me how/where you got these? In your example code I see it happen on the home URL. Did it occur anywhere else?

Plugin Author Rolf Allard van Hagen
(@ravanh)

3 years, 6 months ago

The empty lastmods are maybe related to the fact that you have no posts on your site. Maybe you had before but deleted all? I’ve put a fix in the upcoming release.

if lastmod is enabled (which mine ISN’T anymore) it produces dates that are invalid.

Where do you see these dates? With Lastmod disabled, there should be no dates in the sitemap at all…
Thread Starter ownerstorefly
(@ownerstorefly)

3 years, 6 months ago
First off, I really really appreciate you looking into this… I think regarding the actual dates generated, they are fine. The issue seems to be the generation of items that should be excluded due to insufficient date, like the TLD.

The two errors that google was complaining about (initially) was:

https://storefly.com/blog/
https://storefly.com/

Both of these had no leading “<lastmod>”, no date, but had a closing “<lastmod/>”, which freaks out google and other sitemap checkers.

Since I don’t use a blog, I fixed the “/blog” by “hiding” this page, but the one with the TLD persists, with no way of excluding it.

So maybe the fix should be something like: If there is no valid date, exclude the whole line all together?

Thanks

Mike
- This reply was modified 3 years, 6 months ago by ownerstorefly.
Plugin Author Rolf Allard van Hagen
(@ravanh)

3 years, 6 months ago

Hi @ownerstorefly, indeed that is the fix that is in version 0.5 that was just released…

I’ve also tested with WP Optimize and the sitemaps are cached by that plugin so when you use an external validation service, please be aware that it will probably get a cached version, unless you either manually clear the cache, or make a page/post modification (triggering a cache purge) beforehand.

Let me know how version 0.5 works out 🙂
Thread Starter ownerstorefly
(@ownerstorefly)

3 years, 6 months ago
Thanks Rolf. It appears that the empty date <lastmod> date issue is fixed. However, now there is a new issue.

On the main wp-sitemap.xml file, only the first wp-sitemap-posts-product-1.xml has a lastmod date, all others have no date.

Each product post has 2000 entries, but since I have about 25,000 total products, it has to span into multiple files. Perhaps the <lastmod> date should be the latest out of the 2000 entries?

This is what I’m getting.
```
</sitemap><loc>https://storefly.com/wp-sitemap-posts-page-1.xml</loc><lastmod>2022-11-21T10:42:24-07:00</lastmod></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-posts-product-1.xml</loc><lastmod>2022-11-28T07:30:41-07:00</lastmod></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-posts-product-2.xml</loc></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-posts-product-3.xml</loc></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-posts-product-4.xml</loc></sitemap>
</sitemap><loc>https://
```
storefly.com/wp-sitemap-posts-product-5.xml</loc></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-posts-product-6.xml</loc></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-posts-product-7.xml</loc></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-posts-product-8.xml</loc></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-posts-product-9.xml</loc></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-posts-product-10.xml</loc></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-posts-product-11.xml</loc></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-posts-product-12.xml</loc></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-posts-product-13.xml</loc></sitemap>

</sitemap><loc>https://storefly.com/wp-sitemap-taxonomies-pwb-brand-1.xml</loc><lastmod>2022-11-28T07:30:41-07:00</lastmod></sitemap>
</sitemap><loc>https://storefly.com/wp-sitemap-taxonomies-product_cat-1.xml</loc><lastmod>2022-11-28T07:30:41-07:00</lastmod></sitemap>
Plugin Author Rolf Allard van Hagen
(@ravanh)

3 years, 5 months ago

Hi, no the Lastmod for subsequent sitemaps (after the first one) has not been implemented yet. I’m working on a solution but it may take a while…

Thread Starter ownerstorefly
(@ownerstorefly)

3 years, 5 months ago

Suggestion: If you are generating the main sitemap index first, reverse it. Generate the others first and put it’s information in an array, update as you go, then perform a final write of the main sitemap.xml last.

Plugin Author Rolf Allard van Hagen
(@ravanh)

3 years, 5 months ago

Its a logical thought but the sitemaps are not “generated” in a static sense. They are dynamic, generated “on the fly” on each visit.

But you are right, some kind of pre-fetch caching of the lastmod data is going to be needed. Otherwise generating the index (on the fly) will get too slow on large sites.

Viewing 10 replies - 1 through 10 (of 10 total)

The topic ‘Last Modified dates are invalid’ is closed to new replies.