Leaflet Map and its Extensions

Hi @hupe13,

I expect that when another Map variant is used, elevation for example, it results in an additional JavaScript file/dependency being loaded, which will also have to be blocked in the integration file.

Otherwise the elevation script would be loaded while the others are still blocked, resulting in a failure for the Map to initialize correctly. I see that the current ‘leaflet’ integration doesn’t correctly block all of those scripts and dependencies.

Could you try replacing the Leaflet integration with the below version? I haven’t verified it myself yet, but this version also blocks the Leaflet Extensions and tells them to wait for the “main” Leaflet script to load.

<?php
defined( 'ABSPATH' ) or die( "you do not have access to this page!" );

add_filter( 'cmplz_known_script_tags', 'cmplz_leafletmaps_directory_script' );
function cmplz_leafletmaps_directory_script( $tags ) {
	$tags[] = array(
		'name' => 'openstreetmaps',
		'category' => 'marketing',
		'placeholder' => 'openstreetmaps',
		'urls' => array(
			'WPLeafletMapPlugin',
			'leaflet-gesture-handling',
			'extensions-leaflet-map',
		),
		'enable_placeholder' => '1',
		'placeholder_class' => 'leaflet-map',
		'enable_dependency' => '1',
		'dependency' => [
			//'wait-for-this-script' => 'script-that-should-wait'
			'WPLeafletMapPlugin' => 'leaflet-gesture-handling',
			'WPLeafletMapPlugin' => 'extensions-leaflet-map',
		],
	);
	return $tags;
}

/**
 * Add services to the list of detected items, so it will get set as default, and will be added to the notice about it
 *
 * @param $services
 *
 * @return array
 */

function cmplz_leafletmaps_directory_detected_services( $services ) {
	if ( ! in_array( 'openstreetmaps', $services ) ) {
		$services[] = 'openstreetmaps';
	}

	return $services;
}

add_filter( 'cmplz_detected_services', 'cmplz_leafletmaps_directory_detected_services' );

Let me know if that does the trick!

Kind regards, Jarno

Hi @hupe13,

Any unique identifier that is present in the script that should be blocked (this could be a part of the filename/the full filename, or a part of the path etc).

I used the folder name of your plugin (/extensions-leaflet-map/) as the identifier, so the integration is not dependent on the extension’s file name, but would trigger on any script that contains the extensions-leaflet-mapfolder name.

Kind regards, Jarno

• This reply was modified 3 years, 3 months ago by Jarno Vos.

Hello @hupe13,

Please install this version of Complianz, it will fix the described DNT issue: https://github.com/Really-Simple-Plugins/complianz-gdpr/tree/DNT-on-embedded-content

The cmplz_has_consent function returned ‘false’ in case of DNT, but when the user contents to embedded content, there is consent; and that is what caused the issue to occur.

Curious to hear about your findings with this version.

Kind regards, Jarno

Hi @hupe13,

Would it be possible for you to temporarily re-enable Complianz on the page in question, so that we can take a closer look at the JS errors that appear in the console?

Kind regards, Jarno