• Resolved melindaolson

    (@melindaolson)


    With the recent update the pagination is lost. We have a child theme. We see the pagination file in the parent theme, but we don’t see pagination called from any of the template files.

    The page I need help with: [log in to see the link]

Viewing 5 replies - 1 through 5 (of 5 total)
  • Theme Author Anders Norén

    (@anlino)

    Hi @melindaolson,

    I changed Rowling to use pagination.php for the archive navigation in 2.0.0, to match expected behavior for themes and make it work better with plugins modifying the pagination. If your child theme includes the index.php file, you’ll have to update that file by replacing this line:

    rowling_archive_navigation();

    with this:

    get_template_part( 'pagination' );

    Let me know if that does the trick.

    — Anders

    agarciav

    (@agarciav)

    Hello, this works, thanks, Anders.

    Too works replacing by

    next_posts_link()

    And..a quiestion: it’s possible a infinite scroll replacing this by another function or other code?
    I have tested several plugins “Infinite Scroll” but they don’t work with Rowling theme…

    Thanks,

    MarjoriesDaughter

    (@marjoriesdaughter)

    This is a really nice and simple theme. Thank you for your work!

    But, recently, I had a conversation in another forum platform about situation where a theme or plugin update breaks a child theme because of changed function calls. The overall thought was that a theme or plugin should be considered an API, and not break child themes.

    I believe that the way to do this would be to keep rowling_archive_navigation(); and make the function look something like

    function rowling_archive_navigation()
    {
    get_template_part( ‘pagination’ );
    }

    That way, you can still switch to the function in the WordPress core, which is also a good principle to follow.

    Thoughts?

    Theme Author Anders Norén

    (@anlino)

    Hi @marjoriesdaughter,

    You make a good point. I was a bit hasty in trimming the fat in Rowling, and retaining the function but updating it to include pagination.php would have been a better solution.

    I’ve added the function back in in the latest update, version 2.0.2, which should reduce the risk of the 2.0.0 update breaking child themes. It should be live within an hour or so.

    — Anders

    MarjoriesDaughter

    (@marjoriesdaughter)

    Bravo!

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Lost Pagination’ is closed to new replies.