• Resolved smerriman

    (@smerriman)


    There is a major bug with the way Complianz handles the Adobe Fonts integration.

    Jarnovos mentioned in an earlier thread that all that Complianz does relating to Adobe fonts is ‘block’ the CSS from loading by changing the stylesheet to:

    <link data-service="adobe-fonts" data-category="marketing" rel="stylesheet" id="custom-typekit-css-css" href="#" data-href="https://use.typekit.net/filename.css" media="all">

    This is a gigantic error by Complianz! This does not ‘block’ the stylesheet from loading; it tells the browser there is a stylesheet located at the URL ‘#’, and that it should download it from there.

    # is a valid URL – it’s a relative URL, taking the URL currently being viewed and appending # to it.

    Therefore, after the page is loaded, the browser redownloads the entire page at https://www.mysite.com/# , and tries to interpret it as a stylesheet.

    This results in doubling the load time of the page.

    See https://ww.wp.xz.cn/support/topic/significant-slow-down-with-adobe-type-kit/ for earlier thread where someone had exactly the same issue as I’m having, including seeing the page load time doubled; there the ‘official’ solution was that it wasn’t an error on Complianz site, but that’s definitely not the case.

    Can you please fix this bug – code should *never* use <link rel="stylesheet" href="#" />; this is simply a mistake.

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Contributor Rogier Lankhorst

    (@rogierlankhorst)

    @smerriman thanks for your input. We’re always happy to help resolve issues, but need to be able to reproduce it first. Your explanation of the issue makes sense, which helps to resolve the issue. Without such detailed input it is often hard to track down what really is happening.

    As we manage 26 service integrations and over a 100 plugin integrations, we heavily rely on the input of our free community of contributors, like you.

    I have created a branch which, instead of replacing the href with “#”, removes it altogether. I have passed this to our testing team, who will set it up with this plugin to check how this behaves.

    You can test it yourself using the below branch. Please let me know if this resolves your issue.

    https://github.com/Really-Simple-Plugins/complianz-gdpr/tree/don’t-add-%23-in-blocked-link

    Thread Starter smerriman

    (@smerriman)

    Preliminary testing shows this appears to solve the problem – thanks.

    Plugin Contributor Rogier Lankhorst

    (@rogierlankhorst)

    @smerriman great, thanks for checking 👍

    This will be the issue I flagged last year. Do you know when will this make it into the main branch?

    Plugin Contributor Jarno Vos

    (@jarnovos)

    Hi @delanthear,

    After the fix has been confirmed and passes our testing routines, you can expect it to be included with an upcoming release of the plugin.

    It will be noted in the changelog of the plugin when this is the case.

    Kind regards, Jarno

    Has this been merged in yet? The above github link returns a 404 and I’m still seeing the same issues on my live sites.

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘Major bug in Adobe fonts implementation’ is closed to new replies.