There is a Spanish translation already. And as far I can see, the plugin also uses the correct way to translate strings. What is missing?
Hello Arno,
You’re using the text domain ‘cren-plugin’ when it should be as the ww.wp.xz.cn’s slug ‘comment-reply-email-notification’.
With that change all translations will come to translate.ww.wp.xz.cn:
https://translate.ww.wp.xz.cn/projects/wp-plugins/comment-reply-email-notification/
That is showing that is not properly prepared.
After that, all translations will be moderated for the community local polyglot.
Regards.
To avoid confusion: I am not the plugin author, just another user of this plugin.
Yes, you are right, that a plugin should use it’s slug for the text domain. However the existing translations should work as well. I just noticed, that there are a lot of translation files already including Spanish.
On the other hand it would be helpful, if load_plugin_textdomain() would not require to define the text domain at all – that’s the source of the confusion here.
Yes, but this is how it works. It’s better to have in translate.ww.wp.xz.cn because we can contribute correctly. There are a lot of untranslated strings.
I already forked the code on Github and will try to help the author to fix this. It seems he already opened an issue there for this:
https://github.com/guhemama/worpdress-comment-reply-email-notification/issues/24
I created a pull request with the needed changes. We’ll have to wait until the plugin author is reviewing and merging this.
Thanks for the contribution Arno. I have merged this, lets see how it works! 😀
Thanks for merging. Unfortunately, you forgot to remove the “i18n” folder in the SVN repository – this is not needed any longer and Loco Translate will always complain about unused extra files.
SVN at WordPress:
https://plugins.svn.ww.wp.xz.cn/comment-reply-email-notification/tags/1.10.0/
And this is the source on Github:
https://github.com/guhemama/worpdress-comment-reply-email-notification
For the next update you should remove the i18n folder from the local working copy you use for the SVN commits.
I forgot to adjust some translations in the e-mail template 🙁
I’ll create another pull request, so the notification e-mails will use the translated text again. Sorry for the confusion.
