Max impressions problem

We are planning to switch from the standard ads paid for time to max impressions sold for adverts on our websites. We tried the max impressions. We put a test ad with max impressions set to 8 and keep refreshing website. It did so far 12 impressions and it’s still going.

Before you ask we checked anything that was already posted on internet regarding this:
– we do not use cache on our websites
– code for advert looks fine (decided to put photo url as link to itself for test, bottom of the page)
– our copy of AdRotate is up to date

The ad is posted in group that was posted through shortcode in text element in WPBakery. Also we got installed classic widgets and classic editor plugins if that would interfere.

PS. The link provided is to one of websites but we got the same problem with every website we have.

EDIT – found the root of the problem after looking throught the code.

In function adrotate_filter_schedule there is a calling to the function adrotate_stats. However the colling is set as adrotate_stats($banner->id, $schedule->starttime, $schedule->stoptime) where the actual variables for functions are adrotate_stats($ad, $archive = false, $when = 0, $until = 0).

We checked it by adding the missing variable in calling. That one variable $archive (that seemed to not be used in actual function) was the reason for malfunctions.

Until it is fixed for further updates by the devs themself it prevents from trusting the max impressions setting on the advert scheduling.

• This topic was modified 3 years, 7 months ago by irhak. Reason: Found possible root of problem

The page I need help with: [log in to see the link]