Minor styling question

  • Resolved yosmc

    (@yosmc)


    11 years ago

    First of all, thanks for providing this great plugin.

    I’ve been using it for quite a while now, and the only thing I changed when I started it was to change the spacing between link text and icon from 15px to 12px.

    Now I’ve noticed that, it one of the recent updates, you got rid of the .css file and put the styling inline. The relevant line reads like this:

    $padding = ($icon < 20) ? 15 : 12;

    So now it’s just one line for me to edit, but unfortunately I lose the setting every time I update. Why don’t you make the default setting 12px for all of the icons? It looks much better, I swear! 🙂

    https://ww.wp.xz.cn/plugins/wp-external-links/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Pi Zi

    (@freelancephp)

    10 years, 11 months ago

    Yosmc, you might be right on the 12px, but changing would have effect for all existing users (also users who maybe don’t like the change).
    A solution would be, to add the correction into your own stylesheet (CSS) within your theme, f.e.:

    .ext-icon-1 { padding-right:12px !important; }';

    That wway you don’t have to change after each update.

    Thread Starter yosmc

    (@yosmc)

    10 years, 11 months ago

    Thanks for the suggestion, although I don’t think it’ll work for me – that way, I lose the settings every time I update my themes. 🙂 Plus, instead of putting it in one place, I have to put it in the css file of every theme.

    As for making the the change on your end: I didn’t really hold my breath for this because I’m assuming you went for the 15px because they look best in your eyes. But if you prefer the 12px as well, I think you should go for it – themes and other pieces of programming include style updates all the time, some will always dislike change, but the majority should be happy.

    Pi Zi

    (@freelancephp)

    10 years, 11 months ago

    It’s recommended to create a child theme with specific customization for your site. That way the parent theme can be updated without touching the child theme.
    Why put it in every theme, you just use one theme per site right? Or do you have more sites?

    I don’t know yet if it will make the majority happy 🙂

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Minor styling question’ is closed to new replies.