Update – I have successfully re-installed previous version – 1.3.9 and site is back live.
I realise the error will not be present but should any admin wish to see the site to see if there is anything obvious;
bigburymint.com
Thank you
John
Update 2 – Just in case anyone has to go through the above!
On rolling the plugin back to v1.3.9 I noticed that none of the popups were working. I had to go into each popup in the admin and reselect a “targeting Condition” and then reselect the theme for the popup in order to get them working again.
Sorry if all this is a bit long winded but I want to be as helpful as possible. 😎
This is being caused by the call to return apply_filters( 'popmake_popup_is_loadable', $loadable, $popup_id ); in includes/pum-deprecated.php. The filter function in includes/integrations/class-popmake-woocommerce-integration.php takes 4 arguments and has no defaults.
Either need to change includes/pum-deprecated.php to:
// or whatever the appropriate default values are for args 3 and 4
return apply_filters( 'popmake_popup_is_loadable', $loadable, $popup_id, array(), false );
Or change includes/integrations/class-popmake-woocommerce-integration.php to:
// or whatever the appropriate default values are for args 3 and 4
public function popup_is_loadable( $is_loadable, $popup_id, $conditions=array(), $sitewide=false ) {
This former seems like it would best make it backwards compatible.
@chadwickjs – Looking into this now. Will get this included in the next patch tonight. Planned to be online all night pushing patches as fast as issues get reported. Thanks for the report. Will let you know when I know the solution.
@doublesharp – That looks about right, thanks for reporting the fix. I am about to push v1.4.2 shourtly which will include this once I double check it.
Did either of you process the upgrade routine? Once processed that file shouldn’t be called, just wondering if that has anything to do with it.
In v1.4 after migration is done all new conditions are added and replace that entire class.
I just patched with both suggestions made by @doublesharp, look for a release shortly.
Not immediately, but the upgrade was processed… fwiw I am using nginx, php-fpm, php7, and mariadb so kind of but not really standard.
@doublesharp – Ok I am pushing v1.4.2 including those patches, so if they worked for you should work for everyone else too. Not sure how I missed those :(..
I’m also using a cache, which I just cleared. It doesn’t always flush things as well as one might hope if that could be related.
@doublesharp – No problem, please test v1.4.2 guys and let me know if that solves your problems. or at least this one. Long night ahead for me 🙂
I am getting:
Warning: Cannot modify header information – headers already sent by (output started at /home/XXXXXX/public_html/wp-content/plugins/popup-maker/includes/integrations/class-popmake-woocommerce-integration.php:1) in /home/smocpt/public_html/wp-includes/pluggable.php on line 1171
@adam.coppin – Sorry about that, the last patch had an accidental space added somehwere it should’t be, patch is already pushed, should be available in your dash shortly.
I have had to roll back to 1.3.9 too.. thanks to @chadwickjs for the pointer for resetting the targetting and theme… I ended up having to reset my theme background too, but that fixed everything…
@danieliser – thanks for the extremely rapid response!
Bit late for me tonight, so I may try this again tomorrow…
@adam.coppin – Sorry about that, if you can bear with me through the next day or so, we will get every issue patched very rapidly. This was a massive update, over 5 months in the making, so I knew and planned for a few days of rapid bug patches.
