Missing ID notice

Resolved danbp
(@danbp)

10 years, 11 months ago

Hi,
line 50 of dev version bp-compliments-notifications.php is throwing a php notice.
This error is also in 0.0.1:37

Undefined property: stdClass::$id

To solve this i changed the if clause, from
if ( 1 == $total_items )
to
if ( $item_id && isset ($item_id->ID) && 1 == $total_items )

Hope it’s correct. At least it seems to work.

https://ww.wp.xz.cn/plugins/buddypress-compliments/

Viewing 7 replies - 1 through 7 (of 7 total)

Plugin Author Paolo
(@paoltaia)

10 years, 11 months ago

Hi danbp,

thanks for reporting this. I’ve ask Giri to a have look itno it. Tomorrow we’ll probably release 0.0.3 and we’ll make sure to include this fix.

Cheers,

Plugin Author Paolo
(@paoltaia)

10 years, 11 months ago

Hi,

we believe your fix will throws an error when the format is string.

However we were not able to recreate the problem and see that notice.

Since you mentioned line number 50, we added a working fix here:

https://github.com/GeoDirectory/buddypress-compliments/pull/6/files?diff=unified#diff-3a36c406f3393ce9b4171d1677b66001L50

Could you please test it and let us know,

Thanks
Thread Starter danbp
(@danbp)

10 years, 11 months ago
Hi Paolo,

apologize, i haven’t first mentionned that the notice was only on BP’s Activity (wp-admin/admin.php?page=bp-activity).

What i did for now.
1. Removed my copy and dowloaded from here a new one.
2. Deactivated my copy. Installed the new one and activated it.
The notice comes up.
1. Deactivate the plugin; Reinstalled my copy (which is the dev version from github).
2. Commented my hack and applied your fix.
3. Activate the plugin.
Notice is gone ! Guess it works correctly now. 🙂

Thank you for your reactivity.
Plugin Author Paolo
(@paoltaia)

10 years, 11 months ago

Are you downloading from the correct GitHub page?

https://github.com/GeoDirectory/buddypress-compliments

This one: https://github.com/wp-plugins/buddypress-compliments/

Is autocreated when you submit your plugin to ww.wp.xz.cn, but it’s not the one we use.

Thanks

Thread Starter danbp
(@danbp)

10 years, 11 months ago

Yes i do ! And fixed github version doesn’t throw a notice.

Plugin Author Paolo
(@paoltaia)

10 years, 10 months ago

Excellent! 🙂
Will release it later today!
Thank you

Viruthagiri
(@viruthagiri)

10 years, 9 months ago

@danbp or @paolo,

Please mark this as resolved

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘Missing ID notice’ is closed to new replies.