Missing shadow-box for white square view | ww.wp.xz.cn

R. Fuchs
(@ronaldfuchs2016)

9 years, 1 month ago

A missing css notation in gallery-owl-carousel.css line 159 disables the very cool shadow-box option. The backend (admin area) works correctly.

Please add following:
body .foogallery-owl-carousel.border-style-square-white a,
I’m using version 1.4.2 of this very nice extension.

Thank you!

Viewing 4 replies - 1 through 4 (of 4 total)

Plugin Author Matt Cromwell
(@webdevmattcrom)

9 years, 1 month ago

Would you mind submitting an issue here:
https://github.com/mathetos/foogallery-owl-carousel-template/issues

Or even better a PR if you’re familiar with that?

Thanks!

Thread Starter R. Fuchs
(@ronaldfuchs2016)

9 years, 1 month ago

Hi Matt,
there is always a first time…
i signed up to github and make a pull request with a reference to this thread here.
Hope it works.

Plugin Author Matt Cromwell
(@webdevmattcrom)

9 years, 1 month ago

Hmmm…. I don’t see your PR at all. Normally, it would appear here:
https://github.com/mathetos/foogallery-owl-carousel-template/pulls

Perhaps you pushed it to your fork, but didn’t do the PR to my branch at all?

Here’s a good guide on PRs in Github:
https://help.github.com/articles/about-pull-requests/

Thanks!

Thread Starter R. Fuchs
(@ronaldfuchs2016)

9 years, 1 month ago

Hello Matt,
its done. The PR is created.
You was right, i made a PR for my own fork.
I found a way to compare across the forks – it is easy if you know how to do it.

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Missing shadow-box for white square view’ is closed to new replies.

4 replies
2 participants
Last reply from: R. Fuchs
Last activity: 9 years, 1 month ago
Status: not resolved