Missing string in translation file

  • Resolved Yordan Soares

    (@yordansoares)


    6 years, 7 months ago

    Ciao @dueclic!

    I’m very happy using your plugin. When I was translating your plugin to Spanish (es_VE and es_ES) I noticed that there is a string that you forgot to format with the translation function __():

    title="<?php __( "Are you lost?", "two-factor-login-telegram" ); ?>"><?php echo sprintf( '&larr; Torna a %s', get_bloginfo( 'title', 'display' ) ); ?></a>

    You just must to wrap the string into the __() function passing the string as first param and text domain as second param:

    title="<?php __( "Are you lost?", "two-factor-login-telegram" ); ?>"><?php echo sprintf( __("&larr; Torna a %s", "two-factor-login-telegram"), get_bloginfo( 'title', 'display' ) ); ?></a>

    It would be great if you include this change in next release 😉

    Thanks for share your plugin!

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author dueclic

    (@dueclic)

    6 years, 7 months ago

    Hi Yordan,

    I thank you for appreciating my plugin and for making it usable even to those who speak Spanish 🙂 .
    Thanks also for the report you made to me, I have created a new version fixing the bug.

    Unfortunately my work does not allow me to follow the project too much, but I think there are many other interesting features to develop.
    I’m looking for other passionate developers who want to expand with me the plugin and make it better. If you’d like to be part of the team, you’d be welcome.

    p.s: if you want you can leave a review of the plugin, this will allow us to grow it 🙂

    Thread Starter Yordan Soares

    (@yordansoares)

    6 years, 7 months ago

    Hi @dueclic,

    I already leave a review. I also talk about your plugin in a meetup a month ago, you can watch it here (39:35).

    It will be a pleasure for me to be part of the plugin team. I have two ideas to improve «WP Two Factor Authentication with Telegram»:

    1. Add a filter to custom the logo (e.g.: when you want the same logo of site for both login screen: WordPress and WP TFA with Telegram)
    2. Add an optional field to include the name or URL of site in the Telegram message of failed access. Specially useful when you use same bot for different sites. (e.g.: Failed attempt to access from YordanSoar.es for the user: admin (IP: 127.0.0.1))

    I can work on that if you agree. By the way, you can find me in Telegram with username: @yordansoares.

    A presto!

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘Missing string in translation file’ is closed to new replies.