Missing translation strings

  • Resolved Bonaldi

    (@bonaldi)


    7 years, 8 months ago

    Hi,
    Missing , 'wp-members' in translations are:

    tab-options.php,

    lines 66 and 67

    'post' => __( 'Posts' ),
'page' => __( 'Pages' ),

    line 185
    array(__('Enable Products', 'wp-members'),'wpmem_settings_products',__('Enables creation of different membership products'),'enable_products'),

    post.php,

    line 158

    'post' => __( 'Posts' ),
'page' => __( 'Pages' ),

    line 214
    _e( 'Status:', 'wp-members' ); ?> <span id="wpmem_post_block_status"><?php echo $post_meta_settings[ $post_meta_value ]['text']; ?></span> <a href="#" class="hide-if-no-js" id="wpmem_edit_block_status"><?php _e( 'Edit' ); ?></a>

    line 228
    <p><a href="#" class="hide-if-no-js button" id="wpmem_ok_block_status"><?php echo _e( 'OK' ); ?></a> <!--<a href="#" class="hide-if-no-js" id="wpmem_cancel_block_status"><?php _e( 'Cancel' ); ?></a>--></p>

    Hope you will make change on next update…
    Regards.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Chad Butler

    (@cbutlerjr)

    7 years, 8 months ago

    Thanks for your message. I’ll get the text domain added to the “Enables creation of different membership products” string. However, the remaining strings here that do not have a text domain are WP strings, which is why the text domain is omitted.

    Thread Starter Bonaldi

    (@bonaldi)

    7 years, 8 months ago

    It’s a mistake: strings are not translated without text domain.
    Even if they are WP strings…

    Plugin Author Chad Butler

    (@cbutlerjr)

    7 years, 8 months ago

    Not trying to be argumentative, but that’s not correct.

    The text domain argument in all of WP’s I18n functions is an optional argument. If not passed, it defaults to “default” which identifies it as the WP default text domain, which is loaded by load_default_textdomain().

    Functionally, there is no difference between __( 'Pages', 'default' ) and __( 'Pages' ) because ‘default’ is the default value of the second argument ( see: __()).

    If this were not the case, then no default WP strings in core would be translated as they all omit the text domain (because they are default strings).

    Thread Starter Bonaldi

    (@bonaldi)

    7 years, 8 months ago

    You are right Chad, but in post.php, line 157 and 158 you wrote this hard string:

    	$post_arr = array(
		'post' => 'Posts',
		'page' => 'Pages',
	);

    will this be translated ? 😉

    Plugin Author Chad Butler

    (@cbutlerjr)

    7 years, 8 months ago

    Absolutely! 🙂

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Missing translation strings’ is closed to new replies.