Thanks @dominikshaim. I’ll test that out.
@donncha: OK 🙂
Difference is:
function_exists = checking if function exists but not if is possible to call it (because disabled_functions for example)
is_callable = this is checking if function is able to be called, return false, if function is in disabled_functions 🙂
I think, it will be better option to “switch” from function_exists to is_callable.
Does the drop-in apache_request_headers() function work well for you?
To avoid problems I’ll add a “wpsc_” to the function name and put the is_callable() check inside there. The PHP docs have more complicated fallback functions in the comments, but I’d rather not replace that part of the code if it’s working.
We dont use apache_request_headers function. We block this function.
is_callable will solve problem I think 🙂
OK, this PR should fix things. I’d appreciate it if you could test it: https://github.com/Automattic/jetpack/pull/39951
We don’t use this plugin longer time 🙂 From 2022. So I can’t test it. I am only reporting old problem for you for future improvement 🙂
I checked this PR, commits looks good on first look 🙂
-
This reply was modified 1 year, 7 months ago by
dominikshaim.
Thanks for the update.
@donncha It looks like we’ll need to do some extra testing on our end to confirm your PR fixes the issue.
I’m going to mark this thread as solved. If you have any further questions or need more help, you’re welcome to open another thread here. Cheers!
