Not compatible with numeric navigation on comment pages?

  • Resolved Tooni

    (@tooni)


    4 years, 12 months ago

    Hi, I’m using the highlight search terms plugin for some time now and it works fine.

    Now after several of my posts have got a large number of comments I activated the standard WP function for paginated comments and also activated a numeric navigation for the resulting comment pages. This also works fine.
    When clicking e.g. on page no.6 of these page numbers, the resulting url will look like:
    my-site.com/mypost/comment-page-6/#comments
    and this calls the sixth page. Fine.

    However – this doesn’t work together with the highlight plugin. 🙁

    After performing a search and calling one of the result pages, this will have an url like:
    my-site.com/mypost/?hilite=’search-term’
    When I now click on one of the numeric navigations this will result in:
    my-site.com/mypost/?hilite=’search-term’/comment-page-6/#comments

    Unfortunately this doesn’t call the intended post, but instead just moves the display 2-3 lines up.

    So it seems that the highlight plugin is not compatible with paginated comments with numeric navigation? Or do you have some advise what I can do?

    Regards, Tooni

    • This topic was modified 4 years, 12 months ago by Tooni.
Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Rolf Allard van Hagen

    (@ravanh)

    4 years, 12 months ago

    Hi Tooni, it looks like you found a bug. Thanks for reporting it 🙂

    I’ll have to work on this and will let you know…

    Plugin Author Rolf Allard van Hagen

    (@ravanh)

    4 years, 12 months ago

    Hi again, it turns out to be a tricky conflict between two internal WordPress functions: add_query_arg() used in a post_link filter in this plugin and paginate_comments_links() used in many themes comments.php template.

    I think I’ve managed to work around the issue in the new development version 1.5.7 which you can download from
    https://downloads.wp.xz.cn/plugin/highlight-search-terms.zip

    Upload the zip via your WordPress admin Plugins > Add new, then choose to upgrade.

    Let me know if the patch works for you 🙂

    Thread Starter Tooni

    (@tooni)

    4 years, 12 months ago

    Wow! This was a really great support. Your solution is working fine (as far as I can see up to now).
    Thank you very much for this quick response and solution!!

    Regards, Tooni

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Not compatible with numeric navigation on comment pages?’ is closed to new replies.