Not sure which version it stopped working

  • Resolved jemcfarlandiii

    (@jemcfarlandiii)


    1 year, 3 months ago

    Haven’t changed anything since the last issue. Nothing shows – the shortcode is not displaying like last time but neither is the widget. I tried going back a version or two without success.

    Here is debug for one movie:
    [DEBUG][Lumiere][Widget_Frontpage] Shortcode [lumiereWidget] added.
    [DEBUG][Lumiere][Widget_Frontpage] Custom field lumiere_widget_movieid found, using “tt21862626” for querying
    [DEBUG][Lumiere][Movie_Display] Using the link maker class: Bootstrap_Links
    [DEBUG][Lumiere][Movie_Display] The following plugins compatible with Lumière! are in use: [imdbphp][DEBUG][Lumiere][Movie_Display] searching (no movie name)
    [INFO][Lumiere][Movie_Display] No Movies+series found for (no movie name), aborting.

    Confirm to be using latest version.

    The page I need help with: [log in to see the link]

Viewing 11 replies - 1 through 11 (of 11 total)
  • Plugin Author JCV

    (@psykonevro)

    1 year, 3 months ago

    It may be related to the field of the widget you’re using: “tt21862626” is not a valid one.

    Could you try to take out the “tt”, so you have “21862626” only and report back if it works?

    Plugin Author JCV

    (@psykonevro)

    1 year, 3 months ago

    If my guess is correct and you were able to get the plugin back to work with above method, you can add this piece of code into the file functions.php in your theme folder:

    add_filter( 'lum_find_movie_id', function( array $movies_array ) { 
	foreach( $movies_array as $key => $value ) {
		$movies_array[ $key ] = str_replace( 'tt', '', $value );
	}
	return $movies_array;
}, 10, 1 );

    This will automatically remove all ‘tt’ from all past posts.

    (Out of curiousity, why did you add ‘tt’ before the IMDb IDs?)

    Thread Starter jemcfarlandiii

    (@jemcfarlandiii)

    1 year, 3 months ago

    (Out of curiousity, why did you add ‘tt’ before the IMDb IDs?)

    Because that has always appeared to me to be a legitimate part of the ID. Remove the TT from the URL it will not work – do not use the TT when using the IMDB search box and it will not bring up your movie – the tt has to be included to bring it up. I am surprised that you are asking me this to be honest.

    Thread Starter jemcfarlandiii

    (@jemcfarlandiii)

    1 year, 3 months ago

    Yes – removing the tt did bring it up.

    Plugin Author JCV

    (@psykonevro)

    1 year, 3 months ago

    Yes – removing the tt did bring it up.

    Yepee. So normally using the code I shared should bring back all your movies.

    Because that has always appeared to me to be a legitimate part of the ID. Remove the TT from the URL it will not work – do not use the TT when using the IMDB search box and it will not bring up your movie – the tt has to be included to bring it up. I am surprised that you are asking me this to be honest.

    Sorry, I don’t get it and do not know what URL you are talking about. Could you please elaborate? If I put somewhere a misleading information, I need to fix.
    The Imdb search box is supposed to return plain IMDb ids (without ‘tt’), and when you click on a IMDb id, it should copy the IMDB ID only.
    That’s why I’m wondering how come you started using the prefix ‘tt’, which may be due to a mistake I made at some point.

    Thread Starter jemcfarlandiii

    (@jemcfarlandiii)

    1 year, 3 months ago

    Go to IMDB.com – they have a search box. If I put in the ID above without the TT the movie does not come up – If I add the TT it does come up. There have been other apps before that required the usage of the identifier prefix letters also and even IMDB always includes the identifier prefixes in their talks about the IDs.
    https://developer.imdb.com/documentation/key-concepts
    https://developer.imdb.com/documentation/bulk-data-documentation/data-dictionary/names << -they use tt in their own code
    Regardless, I am just trying to get this to work for my site as I am committed at this point and will use whatever I have to.
    I have done it this way for years and used your app doing it – my question is why did you decide to change the way you handle the “tt”?

    Plugin Author JCV

    (@psykonevro)

    1 year, 3 months ago

    Go to IMDB.com – they have a search box.

    I get it now. How come you don’t use the search box provided by the plugin? Any particular reason?

    Regardless, I am just trying to get this to work for my site as I am committed at this point and will use whatever I have to.

    Please report back should the code I provided not to work. It should be easy to implement, and sustainable – except if you change your theme, you’ll have to do it again.

    I have done it this way for years and used your app doing it – my question is why did you decide to change the way you handle the “tt”?

    The plugin wasn’t handling the “tt”. This was from your perspective a feature, from the developper perspective a security issue. I’ve been improving security of the plugin lately. But also added flexibility, which should be convenient for you. Such a simple piece of code for editing movie’s id wouldn’t have been possible before.

    To make it short: the plugin should have rejected from the outset an imdb id starting with “tt”. Now it does, but you can easily change its behaviour.

    Please let me know how it goes.

    • This reply was modified 1 year, 3 months ago by JCV.
    Thread Starter jemcfarlandiii

    (@jemcfarlandiii)

    1 year, 3 months ago

    I’ve always retrieved the IMDBID from the URL for the movie so I never noticed nor attempted to use your query tool – which just comes up with “Does Not Exist” no matter what I tried with it a few minutes ago.

    https://www.imdb.com/title/tt21862626/

    The IMDBID is always included in the URL for the movie itself.


    I added your code to an extra module I INCLUDE that has other things I need added as well. If I add it to Functions.php it will disappear with next upgrade so I just have to add the include directive now and it re-appears – much easier this way. Your code is doing what you expected it to do.

    Wonder why IMDB themselves includes the “tt” in their coding examples?

    Thanks for your help.

    Plugin Author JCV

    (@psykonevro)

    1 year, 3 months ago

    I’ve always retrieved the IMDBID from the URL for the movie so I never noticed nor attempted to use your query tool

    You found by yourself a creative way 😉

    which just comes up with “Does Not Exist” no matter what I tried with it a few minutes ago.

    What does come up with “does not exist”, the query itself or the windows? You should get an extra window by clicking on any of the two same links (“the query tool” or “IMDb movie ID”) when editing a post. Here is a screenshot (in somewhat red the two links)
    screenshot
    The query might be less successful than IMDb’s, though, but a window should popup.

    Your code is doing what you expected it to do.

    Glad you found a way to get it back. If you’re using the plugin for years, I guess you have many posts.

    Wonder why IMDB themselves includes the “tt” in their coding examples?

    It’s historical. IMDb started with two very different types of pages: movies and people. They added “tt” for movies (I guess it means “title”) and “nm” (dunno what it stands for, “no movie”? No idea).

    Do not hesitate also to let me know should you need a new feature or information from the IMDb. I mainly code the plugin for my own needs, but since it’s now much easier to retrieve info from the IMDb, will be happy to add extra info, be it in the information displayed into the posts or in the people/movies popups.

    • This reply was modified 1 year, 3 months ago by JCV.
    Thread Starter jemcfarlandiii

    (@jemcfarlandiii)

    1 year, 3 months ago

    Glad you found a way to get it back. If you’re using the plugin for years, I guess you have many posts.

    5600+ posts – not all use Lumiere but I started using it as soon as I discovered it and have upgraded many of the older posts to use it as well. Before that – I went to the movie page and copy and pasted it all. You have saved me much work! Again.. thank-you.

    Plugin Author JCV

    (@psykonevro)

    1 year, 3 months ago

    thanks for your kind words 😉

Viewing 11 replies - 1 through 11 (of 11 total)

The topic ‘Not sure which version it stopped working’ is closed to new replies.