I think this might be a problem with it being a Windows server, which is not the ideal testing scenario for the development tools we are using internally.
It would be amazing if you can help us find what it might be or log the issue pointing out the problem, on our GitHub Repository so we can try to solve it.
There are two separate issues that I think are worth logging separate.
- First is an improvement to the warning about
contributor_ignored, which is basically telling you that the format chosen for your contributors might have an error.
- The second is a problem with Windows and PHP Code Sniffer code execution. That is a bit harder to determine the source of the problem.
For the second problem you might be able to solve by using an online host that is hosted on a Linux based machine.
Thank you so much for the report.
For contributor_ignored, I get this error for EVERY plugin, including bbPress, Plugin Check, WooCommerce…..
Also, I used PHPCS and WPCS as a standalone for my development, and it also works just fine under Windows. And, this version of the plugin works just fine on my setup: https://github.com/10up/plugin-check/ the plugin is only the official ww.wp.xz.cn plugin. I am not sure how different these two plugins are under the hood, but 10up version is OK.
Milan
I’ve resolved the readme.txt problem, that warning shouldn’t actually run for users, only for WP.org running the Plugin.
https://github.com/10up/plugin-check/pull/276
It’s a difference in implementation, which we will likely fix soon. But would love to get a report on GitHub it helps our team keep track of problems vs questions.
Regarding Failed check_against_phpcs. and Failed check_against_phpcs_review.
I got the same problem locally on windows 10 machine.
### Environment
- WordPress: 6.4-alpha-56665
- PHP: 8.3.0RC2
- Server: Apache/2.4.54 (Win64) PHP/8.3.0RC2 mod_fcgid/2.3.10-dev
- Database: mysqli (Server: 8.0.31 / Client: 8.3.0)
- Browser: Edge 117.0.2045.36 (Windows 10/11)
– Plugins:
* Plugin Check 0.2.1
Same here, I get this for every plugin ( Even hello dolly can’t pass):
- Failed check_against_phpcs.
- Failed check_against_phpcs_review.
I ran it on a website using LAMP stack.
Failed check is a sympton of phpcs command line not outputing valid json.
I have looked into this and can say that the current development next release branch does not suffer this.
If you have this problem it is most likely caused by ‘extra’ output from phpcs such as deprecation warnings, or in my case xdebug not listening.
You can temporaliy patch this version 0.2.1 by changing line
168 of inc/class-phpcs.php
from
$command = $this->php->get_cmd( "{$this->phpcs} $arg_string $path 2>&1" );
to
$command = $this->php->get_cmd( "{$this->phpcs} $arg_string $path" );
i.e. remove the 2>&1 which merges error output into standard output ( and we dont want that )
If that doesnt solve the issue you can ‘log’ the output from the phpcs command on 169
$response = shell_exec( $command );
e.g.
$response = shell_exec( $command );
error_log('PHPCS command:' . $command);
error_log('PHPCS reponse:' . $response);
Whch will log to your error log or debug log accordingly.
The response should be valid JSON
-
This reply was modified 2 years, 6 months ago by
Alan Fuller.
