Overwrite wp_popup_content with custom ACF fields + developer docs?

Hi, I’ve been trying to figure out how to get some ACF fields I’ve add to the pop up post type. I can get something working, but it seems overly complicated and was wondering if there is a better way of doing this

https://gist.github.com/mvaneijgen/b495261a446e7fffc6517b2d31cc68dd

I’ve looked for some developer docs on https://support.cornershopcreative.com/support/solutions/folders/43000257398 but this docs seems to be only targeted to users and I can’t find anything for developers. If I’ve overlooked something please direct me to the correct docs.

Also is there a particular reason you’re not using the <dialog> element. I’ve not yet done any testing, but I know the dialog element is accessible out of the box.