Patch: I would like it to fail nicely - [Insert Pages] Review | ww.wp.xz.cn

charleyramm
(@charleyramm)

10 years, 11 months ago

I would like it to fail nicely when it doesn’t find the page I wanted to insert.

I don’t know how to submit a patch.

4c4
< Plugin Name: Insert Pages (patched)
—
> Plugin Name: Insert Pages
221,223c221
< } else { // the query did not return any posts
< print “<p>’$page’ could not be inserted because it wasn’t found</p>”;
< }
—
> }

Viewing 2 replies - 1 through 2 (of 2 total)

Plugin Author Paul Ryan
(@figureone)

10 years, 11 months ago

Would it be okay with you if I added that as a filter? Other users prefer it to fail silently (i.e., no page output). I can add a filter at that spot in the code that you can override in your theme to provide whatever output you want.
Plugin Author Paul Ryan
(@figureone)

10 years, 11 months ago
Hi, version 2.7.1 adds a filter so you can add a custom message when a page cannot be found.

https://ww.wp.xz.cn/plugins/insert-pages/changelog/
https://bitbucket.org/figureone/insert-pages/commits/4f226cc1697f4368faad95be44dd8074218341a9

Example usage:
```
function theme_init() {
    // Show a message in place of an inserted page if that page cannot be found.
    add_filter( 'insert_pages_not_found_message', function ( $content ) { return 'Page could not be found.'; } );
}
add_action( 'init', 'theme_init' );
```

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘Patch: I would like it to fail nicely’ is closed to new replies.

2 replies
2 participants
Last reply from: Paul Ryan
Last activity: 10 years, 11 months ago