Performance issues with Flexible Product Fields plugin
-
Hi team,
I am finding this plugin to be extremely heavy on database queries (44 per product page, more on archives).
An analysis shows that the plugin runs database queries in the 7 different template finders, multiplied for each hook section it uses on the PDP (eg.
woocommerce_before_add_to_cart_button,woocommerce_after_add_to_cart_buttonetc. None of the data is reused between templates.These also run during
Flexible_Product_Fields_Plugin->wp_enqueue_scripts()as well as for any other products, including upsells, related products, or product summary tiles on the PDP or archive / PLP.Due to the way caching is being done, each hook section has a different cache key, so nothing can be pulled from cache. One suggestion would be to reuse the
''section cache key for each individual section call, but really you should be sharing data between the templates without going back to the database.The result of this poor code is big increases in CPU/load with the plugin enabled.
Can you please ask your development team to look at the architecture of how you’ve included templates / scripts and where you cache data to avoid multiple queries during the execution of the plugin?
Thanks, Jason
-
Hi guys,
I did a few things inflexible-product-fields/src/Service/TemplateFinder/TemplateFinder.php; the most effective were:
1. Disable all templates I do not use on my site.private function init_finders(): void {
$this->finders->add( new ProductTemplateFinder() );
- $this->finders->add( new CategoryTemplateFinder() );
- $this->finders->add( new TagTemplateFinder() );
- $this->finders->add( new AllTemplateFinder() );
- $this->finders->add( new ProductExludedTemplateFinder() );
- $this->finders->add( new CategoryExludedTemplateFinder() );
- $this->finders->add( new TagExludedTemplateFinder() );
+ // Disabled unused template finders - we only assign to specific products
+ // $this->finders->add( new CategoryTemplateFinder() );
+ // $this->finders->add( new TagTemplateFinder() );
+ // $this->finders->add( new AllTemplateFinder() );
+ // $this->finders->add( new ProductExludedTemplateFinder() );
+ // $this->finders->add( new CategoryExludedTemplateFinder() );
+ // $this->finders->add( new TagExludedTemplateFinder() );
}2. As your
enqueue_scriptshook effectively primes the cache for all section types but it never gets used, modify the lookup to check for cached values first.+ private const META_KEY_SECTION = '_section';
+
protected FinderCollection $finders;
protected ProductHandlerInterface $product_handler;
@@ -45,6 +47,22 @@
return $this->cache->get( $product, $section );
}
+ // If requesting a specific section but we already have ALL templates cached,
+ // filter in PHP instead of running new queries
+ if ( $section !== '' && $this->cache->has( $product, '' ) ) {
+ $all_templates = $this->cache->get( $product, '' );
+ $filtered_posts = array_filter(
+ $all_templates->get_posts(),
+ function( $post ) use ( $section ) {
+ return \get_post_meta( $post->ID, self::META_KEY_SECTION, true ) === $section;
+ }
+ );
+ $templates = new TemplateCollection( array_values( $filtered_posts ) );
+ $templates->init_fields( $this->product_fields->get_field_types() );
+ $this->cache->set( $product, $section, $templates );
+ return $templates;
+ }
+
$this->product_handler = $this->get_product_handler( $product );
$this->template_query->set_section_hook( $section );I can’t confirm these fixes work on all sites but they reduced the number of DB queries by an order of magnitude for me.
Hopefully your devs can take this inspiration and do better than me!
@rzepsen you did not give me much time to reply!
2.14.3 only provides a small relief.
Your devs ignored the patch I provided for caching. This provided some big benefits.
I have also developed another patch, this one to avoid nested/repeating
get_options()calls fromget_field_type_settings()which is called multiple times ininit_fieldson every front end request. This also calls theshort_urlfilter for the upgrade to pro URLs among other redundant things only needed in admin.This patch provides a reduced set of data back on frontend calls, eliminating the
get_optionscalls.--- wp-content/plugins/flexible-product-fields/src/Field/Type/TypeIntegration.php
+++ wp-content/plugins/flexible-product-fields/src/Field/Type/TypeIntegration.php
@@ -77,6 +77,35 @@
* @return array Settings of field type.
*/
private function get_field_type_settings(): array {
+ if ( ! is_admin() ) {
+ return [
+ 'type' => $this->type_object->get_field_type(),
+ 'value' => $this->type_object->get_field_type(),
+ 'template_file' => $this->type_object->get_template_file(),
+ 'is_available' => $this->type_object->is_available(),
+ 'has_required' => $this->type_object->has_required(),
+ 'has_max_length' => $this->type_object->has_max_length(),
+ 'has_placeholder' => $this->type_object->has_placeholder(),
+ 'has_value' => $this->type_object->has_value(),
+ 'has_css_class' => $this->type_object->has_css_class(),
+ 'has_tooltip' => $this->type_object->has_tooltip(),
+ 'has_value_min' => $this->type_object->has_value_min(),
+ 'has_value_max' => $this->type_object->has_value_max(),
+ 'has_value_step' => $this->type_object->has_value_step(),
+ 'has_options' => $this->type_object->has_options(),
+ 'has_date_format' => $this->type_object->has_date_format(),
+ 'has_days_before' => $this->type_object->has_days_before(),
+ 'has_days_after' => $this->type_object->has_days_after(),
+ 'has_dates_excluded' => $this->type_object->has_dates_excluded(),
+ 'has_days_excluded' => $this->type_object->has_days_excluded(),
+ 'has_week_start' => $this->type_object->has_week_start(),
+ 'has_max_dates' => $this->type_object->has_max_dates(),
+ 'has_today_max_hour' => $this->type_object->has_today_max_hour(),
+ 'has_price' => $this->type_object->has_price(),
+ 'has_price_in_options' => $this->type_object->has_price_in_options(),
+ 'type_object' => $this->type_object,
+ ];
+ }
return [
'type' => $this->type_object->get_field_type(),
'field_group' => $this->type_object->get_field_group(),Please consider mainlining both this and the caching patch!
You must be logged in to reply to this topic.
