Plugin Author
anmari
(@anmari)
Hi Joy,
It’s strange and a bit frustrating exactly what that checker plugin is complaining about.
I ran through most(all?) my plugins a while back and checked/converted all line endings, so was a bit surprised to see this.
So anyway, that compatibility checker plugin won’t run on my windows localhost so hard to test here. I checked some of my remote sites, it did complain about that plugin, and not a similar plugin created with same editor.
I played around a bit and deleted any php closing tags that had no line endings at all and ftp’ed up and that fixed that site. But other plugins that it does not complain about have the php ?> as last characters in their file, so can’t be that. Put it back in that plugin, and it is still happy – go figure.
Possibly there is something odd in their code sniffer. I am not keen to spend too much time chasing this since it is not affecting any plugin functionality, and maybe a anomaly.
Rest assured I will keep the ‘compatability checker’ active on my remote sites and see if I can tell what is causing it to think this.
Just be really handy if I it would run on a windows localhost test site!
Thread Starter
Joy
(@joyously)
I don’t understand why it would not run on a windows localhost. I tried it on mine, which is running XAMPP 1.7.3 (I think it has PHP 5.3.1), and it ran but they all say that “it was skipped as it was too large to scan before the server killed the process”. Is that what you are getting? Perhaps there’s a timeout value that can be changed in php.ini.
The message itself is not really about PHP compatibility, I think. But that the checker could have a problem because of the mixed line endings?
When I switched from Windows 7 to Ubuntu around January (new laptop), I had some issues with editors not liking the line endings of my text files. I had to choose different settings with my preferred Windows editor (which I run with Wine under Ubuntu), and on other editors like Sublime and Brackets, I had install an extension to handle the various encodings (Brackets only did UTF8). But I’m not uploading code for people to use, so I don’t know if what I did works right. We used to have this sort of problem on a theme I collaborated on, because the author used a Mac. Making sure the editor knows about the BOM, and whether to put it or not could be a factor.
On the theme review team, we don’t allow files to have mixed line endings, but it is checked on upload.
You’ll be hearing more about PHP version compatibility as this ticket gets going.
Plugin Author
anmari
(@anmari)
Hi Joy,
the files don’t appear to have mixed line endings, so the question is what is that plugin picking up?
and for myself personally? – how much time do i spend figuring that out ?
