PHP 7.1
-
SiteGround says this plugin is incompatible with PHP 7.1. Is this temporary and are you going to do something about this? Or is this permanent?
The page I need help with: [log in to see the link]
-
That is a false positive. Site Reviews has been developed and tested on PHP 5.6 – 7.2. It will automatically deactivate if PHP < 5.6 is detected.
Just to followup on this topic…
I contacted the SiteGround team about this and it seems that it is not a false positive…the incompatibility notice is happening because of 4 different lines of code in the plugin that are performing an action in a way that has been deprecated in newer versions of PHP.
Specifically (for those interested), these line of code are passing an object by reference with the call_user_func_array function; objects should not be explicitly passed by reference as it already does this by default in PHP:
However, it has been confirmed that even though this method of doing things is deprecated, when done with the call_user_func_array and do_action_ref_array functions, it does not break any code, it does not throw any PHP errors, and it does not emit any deprecation PHP notices.
So yes, technically these 4 lines of code in the plugin mean that the plugin is not “compatible” with PHP 7.1, but that does not mean that it will not work. In actual real-world usage, Site Reviews has been tested and is fully “compatible” (i.e. runs as expected with no issues) with all versions of PHP from 5.6 – 7.3.
The next version of Site Reviews will fix the 4 offending lines of code as shown above, but again, to clarify once more, each of those 4 lines of code:
1. does not break any other code
2. does not throw any PHP errors
3. does not emit any PHP deprecation noticesIn other words, Site Reviews should work great on SiteGround websites as is with PHP 7.x enabled.
-
This reply was modified 7 years ago by
Gemini Labs.
It is not a false-positive but a valid check failure.
Althoug it does not break functionality, it is still depricated code that should be updated if you want to have proper PHP 7 support which is declared in version 3.1.2 from January 3rd.
This said, you can still manually switch to PHP 7.1, 7.2 or 7.3 if you believe that there are no issues with the plugin functionality. Our check simply shows a warning that something may go wrong and I think it does what it’s supposed to do in this case.
Dupilicate post, sorry.
-
This reply was modified 7 years ago by
Hristo Pandjarov.
-
This reply was modified 7 years ago by
The topic ‘PHP 7.1’ is closed to new replies.