• Resolved sidtcom

    (@sidtcom)


    ProfilePress uses an outdated version of pelago/emogrifier which is not PHP 8 compatible.

    File: ProfilePressVendor\Pelago\Emogrifier
    Function: handleXpathQueryWarnings
    Line: 1463 – 1469

    With PHP 8 the 5th parameter for callbacks of set_error_handler is omitted. It must be optional.

    wrong:

    public function handleXpathQueryWarnings(
        // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter
        $type,
        $message,
        $file,
        $line,
        array $context
    )

    correct:

    public function handleXpathQueryWarnings(
        // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter
        $type,
        $message,
        $file,
        $line,
        array $context = []
    )

    This is only a fix. It would be better to use the newest version of pelago/emogrifier which out-of-the-box support PHP 8

    With kind regards
    Sebastian Schmidt

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Collins Agbonghama

    (@collizo4sky)

    The latest version doesn’t really support PHP 7, which many of our users are on.

    However, we will are going to make a patch to include the PHP 8 compatibility you reported above.

    I’ll update you when this has been done.

    Plugin Author Collins Agbonghama

    (@collizo4sky)

    Happy to let you know this will be fixed in the next version as we’ve upgraded to v6 of Emogrify.

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘php 8 not completely supported’ is closed to new replies.