Hi @rexsorgatz,
hm, are you calling the filter_markup() method manually somewhere? And would it be possible for you to check if the error also happens when you disable the other plugins and switch to a default theme?
Best,
Florian
Nope, the only thing using filter_markup() is your plugin.
Okay, and what about that?
> And would it be possible for you to check if the error also happens when you disable the other plugins and switch to a default theme?
Sorry, I have been trying to find a way to test it. It’s a large site, so I can’t just turn everything off…
On my dev environment (which is an exact mirror of production), I am unable to reproduce the error. So I think it requires some amount of traffic… which, well, I don’t have on my dev environment.
The referrer intrigues me. wp-cron.php?doing_wp_cron= I do have a couple things running cron jobs. Both of those are backend utilities, which never hit pages, so I don’t see why that would have anything to do with you.
The error is fairly random. A few every hour, on a site that gets 50K views in that time. So it’s not like a dealbreaker. Just thought you might have an idea…
Ah okay, no problem.
On my dev environment (which is an exact mirror of production), I am unable to reproduce the error. So I think it requires some amount of traffic… which, well, I don’t have on my dev environment.
Okay, that’s tricky. Do the cron actions run on the same intervals and the same time? Or can you find out which action it is by comparing the error log time with the start time of the actions?
The error is fairly random. A few every hour, on a site that gets 50K views in that time. So it’s not like a dealbreaker. Just thought you might have an idea…
No, unfortunately not, sorry.
Hi, I have an update….
This error is still firing, but with more frequency. On a development environment, I have been able to isolate the plugin that, when disabled, stops your plugin from throwing the error. It’s this one:
https://ww.wp.xz.cn/plugins/content-cards/
It’s old, but works well for my purposes. It essentially runs a cron job that pulls in OpenGraph data on external & internal links.
If you have thoughts on how to address the problem, please let me know.
Hey @rexsorgatz,
thanks for the investigation! I will install the plugin and try to reproduce the problem. I will keep you posted.
Best,
Florian
Hey,
I installed the plugin and ran the cron event a few times, but nothing in the error log. Does it also throw the error on the dev environment when only the Content Cards plugin and Lazy Loader is active, so that maybe another plugin has something to do with it?
Best,
Florian
Yeah, it’s just those two in conjunction with each other.
I get ~12 errors/day, on a site that has ~600,000 views/day. So it’s not catastrophic… I just wish there was a solution, cuz I hate seeing it in my error logs. 🙂
Yes, I totally understand that.
Which Lazy Loader settings do you use? Maybe I missed something there.
The options I have checked are:
+ Enable lazy loading for iframes
+ Include lazysizes aspectratio plugin
+ Display a loading spinner
Okay, thanks. That did not change anything on my site, unfortunately… What I could do is add an empty default value to the filter_markup parameter, so that it would not throw an error when called without a param.
I hesitate a bit to include such a »fix«, but I think I will not be able to reproduce the issue to find the true cause, so I created a pre-release on GitHub (https://github.com/florianbrinkmann/lazy-loading-responsive-images/releases/tag/v6.0.1-alpha.2), could you check if that fixes the issue? It is the lazy-loading-responsive-images.zip.
Best,
Florian
And the verdict is….
SUCCESS.
It hasn’t thrown an error since installing the patch, 16 hours ago.
Great, thanks for testing! I am currently waiting for feedback on another issue, after that I will release an official version with the fix.
