What are you talking about? Those are Notices not errors.. of course the plugin is compatible with latest WordPress, as you can verify despite any confusing notices.
Thread Starter
jbx
(@jbx)
Dude, no idea, those line numbers are from files in the plugin no? Can’t really provide more details than that.
I was upgrading WordPress to the latest version for someone, who had a theme which used this plugin, and the moment I upgraded I started getting these notices from the plugin in the main admin page. I don’t know why they started to appear after the upgrade. Maybe some settings got lost or something I don’t know what those 4 keys are that the plugin is looking for.
Yeah but like I said, “those are Notices not errors..” — there is a big difference. Scripts can generate Notices all day long and still work fine. Think of them as information for the developer, not as errors.
Thread Starter
jbx
(@jbx)
Yeah, but they appeared on the client’s admin panel, which was weird given that it was working fine before the upgrade, so it seemed something broke. (Not sure if E_NOTICE is ON, its been a month now). They are notices fine, but the message is saying that couldn’t find those values, so if it actually needs them in any of the next lines its not going to behave as expected… just saying. Just because they’re notices it doesn’t mean its not something wrong, (it could be a misspelt variable, uninitialised variable or something like that)… it just means PHP was able to proceed with the execution of the script.
Yes, but that has nothing to do with the plugin but rather how the site is configured. For example, the following configuration in wp-config.php will enable display of WP Debug information:
define('WP_DEBUG', true);
define('WP_DEBUG_DISPLAY', true);
There are similar settings in PHP for enabling, logging, and displaying. Check it out.
Thread Starter
jbx
(@jbx)
OK I will check.
I think you should still fix those lines so that they check if a key in the array or whatever it is exists before trying to access it, otherwise if you’re assuming you have a value set when in fact you don’t its just running into unpredictable behaviour. Defensive programming doesn’t hurt.
Oh I’m all about cleaning up Notices, just a matter of finding the time for free projects. Also, most of my plugins are 100% “Notice free” (or close to it), should you care to investigate. Rest assured, I’ll take care of any notices I find during my next update of this plugin (currently in progress). So I appreciate the feedback but would ping back by saying that using correct terminology doesn’t hurt either.
Thread Starter
jbx
(@jbx)
No worries. Was probably late at night and I just copied and pasted the messages to ask whether anyone else faced the issue.
Lol, the issue of Notices masked as errors.. Seriously though, no problem at all. And I do value your feedback, the plugin is better because of it.
