PHP Notice Undefined variable

  • Resolved JapeNZ

    (@japenz)


    7 years, 3 months ago

    Hi there,
    Just found your plugin and it’s amazing!

    I’m getting a php error in my debug log and thought I should let you know in case it’s something you can fix… or of course something I need to try and fix somehow 🙂

    PHP Notice: Undefined variable: pageTemplateInfoOutput in /wp-content/plugins/wp-asset-clean-up/templates/meta-box-loaded.php on line 105

    The line in question is if ($pageTemplateInfoOutput) { though it seems to be defined in line 57 with $pageTemplateInfoOutput = ob_get_clean();… so I have no idea what’s going on there.

    Let me know if I can provide any other info you might need 🙂

    Kind regards,
    JP

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Gabe Livan

    (@gabelivan)

    7 years, 3 months ago

    @japenz thanks for reporting this. There was a condition set, but it wasn’t triggered all the time, hence the PHP notice error which should not have printed in the page anyway if displaying PHP notice errors are turned off (they should be in a live environment and only log in the error log files for the admins to check).

    I’ve updated the tag, consider deleting the plugin and installing it again 😉 Let me know if you still have this issue!

    PS: I’m offering coupon codes for anyone who discovers any bug (doesn’t matter if it’s a small one) in the Lite version if they are planning to upgrade to the Pro one. If you will ever want to do that, just remember that I can provide you with a discount.

    • This reply was modified 7 years, 3 months ago by Gabe Livan.
    Thread Starter JapeNZ

    (@japenz)

    7 years, 3 months ago

    Hi @gabelivan,
    Thanks for getting back to me so quickly!

    I’ll delete and reinstall tomorrow (2am here at the moment), and let you know if I get any more issues in my error log.

    I’ll be doing some more in depth testing over the next couple of days, but going by what I’ve already seen I’ll be Keen on grabbing a discount code, thanks for the offer! 😁

    Kind regards,
    JP

    Thread Starter JapeNZ

    (@japenz)

    7 years, 3 months ago

    Hi @gabelivan,
    Just doing some testing and the ‘Combine loaded CSS into one file’ doesn’t seem to be doing anything.
    When I run GTMetrix with it on, it shows the same number of external stylesheets as when it’s turned off.

    That all said, WP Rocket doesn’t recommend combining CSS for HTTP/2, so should I not be worried about it or will it improve my page load times if I can get it to work do you think?
    Also, am I better off combining them via WP Rocket or your plugin?

    Thanks for your help!

    Kind regards,
    JP

    Plugin Author Gabe Livan

    (@gabelivan)

    7 years, 3 months ago

    @japenz you have to make sure that any caching was cleared before re-doing the GTMetrix test. In fact, the best way to test it (before you use GTMetrix) is to load the page in Incognito, check if the combined CSS file is loading before <head> and then you can check it on GTMetrix.

    However, if you have HTTP/2 enabled, you can leave the combine feature and just use the minify option which is useful in all situations (HTTP/2 or not), since smaller files are always faster to download 🙂

    You can use WP Rocket for combining/minifying or Asset CleanUp (you can check the functionality of the pages through trial and error), but not both at the same time as you’re using extra server resources.

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘PHP Notice Undefined variable’ is closed to new replies.