• Resolved curtismchale

    (@curtismchale)


    When using this shortcode setup: [bsp-display-forum-index forum= ‘47657, 47661, 47659′ search=’no’ breadcrumb=’no’] we get PHP errors on the search and breadcrumb parameter because the filters return ‘no function’.

    Changing:

    
    		if (!empty( $attr['breadcrumb']) && ($attr['breadcrumb'] == 'no' ) ) {
    			add_filter ('bbp_no_breadcrumb', 'asc_no_breadcrumb');
    		}
    
    		if (!empty( $attr['search']) && ($attr['search'] == 'no' ) ) {
    			add_filter ('bbp_allow_search', 'asc_no_search');
    		}
    

    to

    		if (!empty( $attr['breadcrumb']) && ($attr['breadcrumb'] == 'no' ) ) {
    			add_filter ('bbp_no_breadcrumb', '__return_false');
    		}
    
    		if (!empty( $attr['search']) && ($attr['search'] == 'no' ) ) {
    			add_filter ('bbp_allow_search', '__return_false');
    		}
    

    resolves this issue because it calls the core WP versions to return a false.

    If you have a Github repository I’m happy to provide a patch.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Robin W

    (@robin-w)

    Thanks for posting !

    The code I used was taken from another plugin I have and was moving in, and I must have had it still running when I tested – sorry, it’s a problem with being a one man band !

    It’s great that not only do you bother to let me know, but also you offer a solution, so double thanks.

    I’ll correct this to the next version, which I’ll release in the next coupe of days.

    Plugin Author Robin W

    (@robin-w)

    Now corrected in 3.3.6

    Thanks again for reporting this !!

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘php notices on functions that do not exist’ is closed to new replies.