PHP-Update: continue (2)-issue

  • mottenkiller

    (@mottenkiller)


    6 years, 10 months ago

    Hi,

    there is an issue with landing-page caused by PHP Update:

    This issue causes a warning on top of my website:

    Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /.../wp-content/plugins/landing-pages/classes/class.settings.php on line 755

    Also there is no chance to log into wp-admin, because the warning is parsed before headers are set.

    As a workaround I changed continue in class.settings.php:755 to continue 2.
    Would break be better in this case?
    But next update will cause the same problem, while class.settings.php will be overwritten by it.

    This should be maintained soon…
    How to report this bug?

    thanks!
    mottenkiller

    • This topic was modified 6 years, 10 months ago by mottenkiller.
Viewing 3 replies - 1 through 3 (of 3 total)
  • pingram

    (@pingram3541)

    6 years, 7 months ago

    The issue appears to be a backward incompatibility with PHP 7.3 for the “continue” keyword in Switch statements. Check out the “Continue Targeting Switch issues Warning” section in Backward Incompatible Changes.(https://www.php.net/manual/en/migration73.incompatible.php)

    I did the same and no, don’t want break even though in PHP 7.0 and higher, a break statement is no longer permitted outside a for, foreach or switch statement and gives a fatal error. (Switch results in warning)

    Anyone running PHP7.3 will experience this until they correct their code to be compatible moving forward.

    pingram

    (@pingram3541)

    6 years, 7 months ago

    Also found this: https://make.ww.wp.xz.cn/core/2018/10/15/wordpress-and-php-7-3/

    Plugin Author Hudson Atwell

    (@adbox)

    6 years, 7 months ago

    Hi @pingram3541 @mottenkiller

    Thank you two so much for the heads up. I’m implementing continue 2; now. 2.7.9

    Although I’m not actively developing this tool anymore, I do try and fix it when it needs it. Please contact me via Twitter @atwellpub or Hudson Atwell @ LinkedIn whenever you see bugs like this in the future.

    I do want to rebuild this, I just have a full time job now with Codeable.io so I hardly ever have any dev hours… and the Inbound Now suite is gigantic… too big for just me… and needs to be rebuilt to reflect best understandings learned through its lifetime.

    Happy to network!

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘PHP-Update: continue (2)-issue’ is closed to new replies.