PHP warning message breaks saving Forms

  • Resolved chssdev

    (@chssdev)


    6 years ago

    When full PHP warnings are enabled, saving an ACF Extended form will break when the page tries to render after reloading, due to the warning being interpreted as an HTTP header.

    These are the errors displayed – rest of page is a white-screen-of-death:

    Notice: Undefined index: post in /var/www/html/wp-content/plugins/acf-extended/includes/modules/form/admin.php on line 175

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/wp-content/plugins/acf-extended/includes/modules/form/admin.php:175) in /var/www/html/wp-includes/pluggable.php on line 1281

    Looking at the line containing the first warning, I see:

    $form_id = $_REQUEST['post'];

    Presumably the root cause of the error is due to there being no actual post on the admin-side.

    Replacing with this made the issue go away:

    $form_id = ! empty( $_REQUEST['post'] ) ? $_REQUEST['post'] : null;

    The code following the line seems to accept the null, and fail gracefully with no warnings or errors.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Konrad Chmielewski

    (@hwk-fr)

    6 years ago

    Hello,

    Thanks for the feedback. This issue has been reported last week. It will be fixed in the next patch. Meanwhile, you can apply your fix, or disable the define('WP_DEBUG_DISPLAY', false); in the wp-config.php file.

    Have a nice day!

    Regards.

    Plugin Author Konrad Chmielewski

    (@hwk-fr)

    6 years ago

    Hello,

    Just to let you know that the latest ACF Extended 0.8.6 update fix this issue!

    Have a nice day 🙂

    Regards.

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘PHP warning message breaks saving Forms’ is closed to new replies.