• Resolved Anh Tran

    (@rilwis)


    Hi Yoast team,

    I see that your plugin enqueues CSS in other admin pages, not only yours. The CSS enqueued affect styling of other plugins, such as the settings page of Slim SEO plugin.

    Slim SEO uses react-tabs in its plugin for its own settings page. However, Yoast’s CSS has some CSS for react-tabs, which causes conflicts on Slim SEO settings page.

    It’s best to:

    • Not enqueueing CSS on other admin pages. It’s a best practice for all plugin authors.
    • In case you have to do that (please don’t), please prefix all CSS so it doesn’t affect other pages.
Viewing 12 replies - 1 through 12 (of 12 total)
  • Plugin Support Maybellyne

    (@maybellyne)

    Hello @rilwis

    Thanks for reaching out about the conflict between Yoast SEO and Slim SEO. We don’t recommend using our plugin with other SEO plugins as unexpected behavior might occur.

    However, if you think this is a bug, you can submit a report on GitHub – https://github.com/Yoast/wordpress-seo/issues

    Thread Starter Anh Tran

    (@rilwis)

    Hi @maybellyne,

    Slim SEO offers some plugins which can be used with other SEO plugins. All of them sharing the same admin page and is affected by Yoast SEO.

    Anyway, the fact that Yoast SEO enqueues its CSS on other admin pages still remains and that should be fixed.

    I reported this issue on Twitter and you told me to open a support thread here. And now you tell me to open a Github issue. I think it’s not a good customer support behavior and tracking bugs is your job, not mine.

    @rilwis

    We agree with you regarding creating a bug report from our side. However, due to the fact that you are the one who came across those issues while using other plugins like the Slim SEO plugin in your specific setup, we assume you have a lot of helpful information and suggestion to add in a bug report with test cases and examples.

    Therefore, once you create a bug report, our development team will review it and try to reproduce them. Indeed, your suggestions might help us improve the CSS/JS script load in the admin dashboard.

    • This reply was modified 3 years, 5 months ago by Suwash Kunwar. Reason: link added
    Thread Starter Anh Tran

    (@rilwis)

    Hi @suascat_wp

    This bug is very simple to replicate. Just install Yoast SEO and Slim SEO, then visit Slim SEO settings page at Settings > Slim SEO and you’ll see the bug. There’s probably no need technical details.

    Please just open the issue yourself and let your team fix. I’ll stop here as I think discussion like this is useless.

    Thread Starter Anh Tran

    (@rilwis)

    Please note that before opening this thread, I reported the bug to you on Twitter:

    And I was told to open a topic here. What makes me upset is that now I was told again to open an issue on Github. It should be just a 5 mins task. But now both of us are wasting a lot of time.

    @rilwis Thanks for your reply.

    We attempted to replicate the issue you reported with the Slim SEO plugin and Yoast SEO, but were unable to. Upon installing and activating the Slim SEO plugin and going to Settings>Slim SEO with Yoast SEO also active, no apparent issue was detected (see image here).

    As we aren’t able to replicate the issue you described, it’s likely being caused by something specific to your environment. This is why it would be necessary for you to submit the bug report in this case, as the environment information is part of the necessary information in order to replicate the issue.

    Thread Starter Anh Tran

    (@rilwis)

    Hi @devnihil ,

    Please enable the Redirection feature in Slim SEO and then go to the Redirection tab, add some redirects and you’ll see the errors.

    The problem is the CSS for react-tabs library, which is used in both plugins. Yoast enqueues its own CSS on Slim SEO’s page and causes the conflict.

    @rilwis We’ve added some redirections under the Redirection tab, and this is what we saw. No apparent layout / CSS issue was noted.
    See: https://tinyurl.com/2m8gsjst
    Please note we have deactivated all non-Yoast plugins (except SLIM SEO) and switched to the TwentyTwenty default theme while testing.

    Can you test on your end with similar default setup?

    Thread Starter Anh Tran

    (@rilwis)

    Yes, the screenshot shows the exact issue with the layout. The table in Slim SEO is normally 100% width, like this: https://monosnap.com/direct/ZqjiWk49PSqrmCnpeibdmtqvyq83ee

    Yoast seems to set max width for the table (or react tab content) and causes the issue.

    @rilwis

    I was finally able to reproduce this issue.

    Thank you for suggesting improvement in one of our plugins! You are the first to have reported this, and I’ve created an internal bug report request for this.

    What’s next? 
    Our product team will assess improvement requests in relation to other open bug reports and new features. Based on their assessment, the feature request will be given a priority level. Our developers work on the highest priority first. Unfortunately, this means we cannot give you an estimate if or when they’ll start working on your request.

    If you have any further information that may affect the prioritization, please feel invited to reply to this thread. 

    Thank you so much for your patience so far.

    Thread Starter Anh Tran

    (@rilwis)

    Glad to hear that. Looking forward to to the fix!

    This thread was marked resolved due to a lack of activity, but you’re always welcome to re-open the topic. Please read this post before opening a new request.

    Do know that the report was filed, as said: based on the product team assessment, the feature requests will be given a priority level. Our developers work on the highest priority first. Thank you!

Viewing 12 replies - 1 through 12 (of 12 total)

The topic ‘Please remove CSS on other admin pages’ is closed to new replies.