Plugin activation shows coding errors

  • Resolved micasuh

    (@micasuh)


    5 years, 8 months ago

    Hello Mr Clayton, I have included an image link below, showing what happens after plugin activation. I am using WordPress 5.5.1 with WooCommerce 4.5.2 and Stripe for WooCommerce 3.2.2.

    https://i.ibb.co/0s3DnWL/Screen-Shot-2020-09-26-at-13-21-10.png

    You will find the issue in /includes/admin/class-wc-stripe-admin-notices.php where there are several spaces included that should be removed.

    I hope you will reconsider hosting this code in a public repository so that the community can help you fix or improve your code. I would test this locally and submit a pull request with the fix.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Clayton R

    (@mrclayton)

    5 years, 8 months ago

    Hi @micasuh,

    Thank you for contacting us. Technically it is hosted in a public repo since that’s what the WordPress SVN is.

    Based on the linked screenshot it just looks like a minor html rendering issue related to a notice that was part of the migration from API keys to Stripe Connect. It’s kind of a non-issue since that message is going away in the next release anyway.

    It’s not affecting any functionality since it’s an html message displayed for Admin’s.

    Kind Regards,

    Thread Starter micasuh

    (@micasuh)

    5 years, 8 months ago

    Thanks for the update on the minor issues to know that code is going away. I’ll let you know if this issue appears in the next updates.

    As for SVN, it’s a public repo that is meant for releases only, on purpose. WordPress Docs explicitly state SVN isn’t for development.
    https://developer.ww.wp.xz.cn/plugins/wordpress-org/how-to-use-subversion/#dont-use-svn-for-development

    I know developers who use git for version control for public development before submitting the latest release to SVN to release updates. Providing the ability for pull requests from community, while it might be just me who’s interested in this idea, would help your audience and customers interact even more with your plugins.

    Hope that helps!

    Plugin Author Clayton R

    (@mrclayton)

    5 years, 8 months ago

    Hi @micasuh,

    I am familiar with how to use SVN, it’s a requirement if your plugin is hosted on ww.wp.xz.cn.

    I may consider making the Git repo public so people can interact more with the plugin. I can see several benefits to this including tracking feature requests. I’ll let you know once I have given it proper consideration.

    Kind Regards,

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Plugin activation shows coding errors’ is closed to new replies.