Plugin breaks nav tabs

  • Resolved Thorsten Frommen

    (@ipm-frommen)


    11 years, 5 months ago

    Hi there,

    this plugin breaks several other navigation tabs as it directly operates on the .nav-tab class. You should either consider to limit this to the actual plugin tabs, which might be something like this

    jQuery( '#tab_PDF' ).find( '.nav-tab' ) ...

    and/or better only enqueue the plugin scripts where they are actually needed.

    Kind regards,
    Thorsten

    https://ww.wp.xz.cn/plugins/gravity-forms-pdf-extended/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Jake Jackson

    (@blue-liquid-designs)

    11 years, 5 months ago

    Hi Thorsten,

    We appreciate the feedback.

    We currently have a beta running which corrects this issue. You are free to download it from GitHub. It will be released at the same time as Gravity Forms 1.9.

    Thread Starter Thorsten Frommen

    (@ipm-frommen)

    11 years, 5 months ago

    Hi,

    I just sent a pull request to your development_2 branch. It includes some improvements regarding the admin.js file. In the switch_tabs function, you didn’t limit the nav tabs to the #tab_pdf element.

    Marking this as resolved.

    Kind regards,
    Thorsten

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘Plugin breaks nav tabs’ is closed to new replies.